Skip to content

fix validation error when theme extension deployed with no-build #6146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

craigmichaelmartin
Copy link
Contributor

@craigmichaelmartin craigmichaelmartin commented Jul 22, 2025

WHY are these changes introduced?

Fixes a validation error when an app with a theme extension is deployed with the --no-build flag.

╭─ error ──────────────────────────────────────────────────────────────────────╮
│                                                                              │
│  Version couldn't be created.                                                │
│                                                                              │
│  theme-extension                                                             │
│                                                                              │
│  Validation errors                                                           │
│    • bundle: Only assets, blocks, snippets, locales directories are allowed  │
│                                                                              │
╰──────────────────────────────────────────────────────────────────────────────╯

WHAT is this pull request doing?

Theme extensions manage their own bundling, so use and trust it.

How to test your changes?

  1. Create an app with a theme extension
  2. Run shopify app deploy --no-build and verify it succeeds

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor

github-actions bot commented Jul 22, 2025

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
77.99% (+0.05% 🔼)
13015/16688
🟡 Branches
72.13% (+0.07% 🔼)
6342/8793
🟡 Functions
78.13% (+0.02% 🔼)
3372/4316
🟡 Lines
78.4% (+0.06% 🔼)
12325/15721
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / ConcurrentOutput.tsx
98.36% (-1.64% 🔻)
92% (-4% 🔻)
100%
98.33% (-1.67% 🔻)

Test suite run success

3045 tests passing in 1314 suites.

Report generated by 🧪jest coverage report action from 949bf81

@craigmichaelmartin craigmichaelmartin marked this pull request as ready for review July 22, 2025 17:37
@craigmichaelmartin craigmichaelmartin requested a review from a team as a code owner July 22, 2025 17:37
Copy link
Contributor

We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run pnpm changeset add to track your changes and include them in the next release CHANGELOG.

Caution

DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release.

@craigmichaelmartin craigmichaelmartin force-pushed the 07-22-fix_validation_error_when_theme_extension_deployed_with_no-build branch from 7230e50 to 77b4917 Compare July 22, 2025 17:57
@craigmichaelmartin craigmichaelmartin force-pushed the 07-22-fix_validation_error_when_theme_extension_deployed_with_no-build branch from 77b4917 to 949bf81 Compare July 22, 2025 18:09
@craigmichaelmartin
Copy link
Contributor Author

/snapit

Copy link
Contributor

🫰✨ Thanks @craigmichaelmartin! Your snapshot has been published to npm.

Test the snapshot by installing your package globally:

pnpm i -g @shopify/[email protected]

Tip

If you get an ETARGET error, install it with NPM and the flag --@shopify:registry=https://registry.npmjs.org

Caution

After installing, validate the version by running just shopify in your terminal.
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.

@isaacroldan isaacroldan merged commit f1929c3 into main Jul 23, 2025
30 checks passed
@isaacroldan isaacroldan deleted the 07-22-fix_validation_error_when_theme_extension_deployed_with_no-build branch July 23, 2025 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants