-
Notifications
You must be signed in to change notification settings - Fork 191
fix validation error when theme extension deployed with no-build #6146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix validation error when theme extension deployed with no-build #6146
Conversation
Coverage report
Show files with reduced coverage 🔻
Test suite run success3045 tests passing in 1314 suites. Report generated by 🧪jest coverage report action from 949bf81 |
We detected some changes at Caution DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release. |
7230e50
to
77b4917
Compare
77b4917
to
949bf81
Compare
/snapit |
🫰✨ Thanks @craigmichaelmartin! Your snapshot has been published to npm. Test the snapshot by installing your package globally: pnpm i -g @shopify/[email protected] Tip If you get an Caution After installing, validate the version by running just |
WHY are these changes introduced?
Fixes a validation error when an app with a theme extension is deployed with the
--no-build
flag.WHAT is this pull request doing?
Theme extensions manage their own bundling, so use and trust it.
How to test your changes?
shopify app deploy --no-build
and verify it succeedsMeasuring impact
How do we know this change was effective? Please choose one:
Checklist