Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade storybook packages from 8.0.9 to 8.4.1 #12881

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Germanika
Copy link
Contributor

WHY are these changes introduced?

The pnpm-lock.yaml file is currently broken in main:

ERR_PNPM_BROKEN_LOCKFILE  The lockfile at "/home/runner/work/polaris/polaris/pnpm-lock.yaml" is broken: duplicated mapping key (8175:3)

 [8](https://github.com/Shopify/polaris/actions/runs/11707524346/job/32607095304#step:7:9)172 |       '@babel/core': 7.26.0

WHAT is this pull request doing?

This PR is upgrading the remaining Storybook packages from 8.0.0 to 8.4.1 which fixes the build and unblocks CI.
It should also close the remaining Storybook dependabot PRs.

I've confirmed that pnpm install && pnpm build runs locally now, and I'm able to run Storybook locally again.

Screenshot

Screenshot 2024-11-07 at 6 02 35 PM

How to 🎩

🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines

🎩 checklist

@Germanika Germanika marked this pull request as ready for review November 7, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant