Add activestorage.rbi #108
Conversation
Various methods were not being handled correctly (e.g. `variant?`) for Rails models that were using ActiveStorage. This fixes many of those issues.
And update index.json as well.
connorshea
force-pushed
the
add-activestorage
branch
from
7452621
to
0965278
Compare
|
Updated index.json and I think I've got the checks passing now, after running them locally. |
| "rails" | ||
| ], | ||
| "requires": [ | ||
| "rails", |
There was a problem hiding this comment.
Did it fail without rails dependency and require?
There was a problem hiding this comment.
It should not. Active Storage doesn't depend on Rails.
There was a problem hiding this comment.
Since ActiveStorage::Blob/ActiveStorage::Attachment are technically models, it needs to load the ActiveStorage engine, and the engine failed to load until rails was added as a dependency. Is there a smaller dependency I can use to get the engine to work?
There was a problem hiding this comment.
The problem seems to be there is a require "rails" dependency in ActiveStorage, but it's not declared as a dependency in the gemspec. Same goes for Action Cable, Action Mailbox and Action Text.
| "rails" | ||
| ], | ||
| "requires": [ | ||
| "rails", |
There was a problem hiding this comment.
It should not. Active Storage doesn't depend on Rails.
| "dependencies": [ | ||
| "rails" | ||
| ], | ||
| "requires": [ | ||
| "rails", |
There was a problem hiding this comment.
My previous comment was not correct, this work locally without upstream changes:
| "dependencies": [ | |
| "rails" | |
| ], | |
| "requires": [ | |
| "rails", | |
| "dependencies": [ | |
| "railties" | |
| ], | |
| "requires": [ |
Rails contains a single file and dependencies on all gems (including Railties), Railties has what we actually need.
Type of Change
Changes
Various methods were not being handled correctly (e.g.
variant) for Rails models that were using ActiveStorage. This fixes many of those issues.