[fix]: subflow execution with .#1 #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
also fixes the Shuffle/Shuffle#1492 for shuffle-shared as it was required to actually test my file. |
|
@frikky please have a look :) |
frikky
reviewed
Aug 12, 2024
| {"$exec.#1", false}, | ||
| {"$exec", false}, | ||
| {"$exec.#1.value.#2", false}, | ||
| {"$start_node.#", true}, |
| @@ -159,6 +159,15 @@ func randStr(strSize int, randType string) string { | |||
| return string(bytes) | |||
| } | |||
|
|
|||
| func isLoop(arg string) bool { | |||
| if strings.Contains(arg,"$") && strings.Contains(arg, ".#") { | |||
| pattern := `(^|\.)(#(\d+-\d+)?($|\.))` | |||
There was a problem hiding this comment.
Can we add another if inside the other if that checks for string contains ".#." or string endswith(".#") and just return true if it is?
I want to use the regex as little as possible :)
|
Let's try this one as well now that we got the edgecases handled :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for Shuffle/Shuffle#1463