Fix race when returning tip #244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a race condition when returning the wallet tip and refactors the initialization order within the SingleAddressWallet constructor. Key changes include replacing direct field access with a thread-safe Tip() accessor and reorganizing field initializations for clarity and consistency.
Comments suppressed due to low confidence (2)
wallet/wallet.go:453
- Ensure that the Tip() method is implemented with proper synchronization to avoid further concurrency issues, as this change is intended to fix the race condition.
return sw.Tip(), nil, nil
wallet/wallet.go:1014
- [nitpick] Reordering the field initializations improves clarity; please verify that this order is consistent with the struct definition and does not introduce unintended side effects.
addr: types.StandardUnlockHash(priv.PublicKey()),
ChrisSchinnerl
requested changes
May 28, 2025
ChrisSchinnerl
previously approved these changes
May 28, 2025
lukechampine
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.