Skip to content

Add RecommendedFee and broadcasting methods to SingleAddressWallet #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 3, 2025

Conversation

ChrisSchinnerl
Copy link
Member

No description provided.

@Copilot Copilot AI review requested due to automatic review settings June 3, 2025 08:47
@github-project-automation github-project-automation bot moved this to In Progress in Sia Jun 3, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds broadcasting methods and a fee recommendation mechanism to the SingleAddressWallet. It updates the wallet creation signature to require a syncer, introduces new methods in the ChainManager interface, and updates related tests and RPC handling to use these changes.

  • Updated wallet creation in tests to include a MockSyncer.
  • Added BroadcastTransactionSet, BroadcastV2TransactionSet, and RecommendedFee methods to SingleAddressWallet.
  • Updated ChainManager interface and associated tests and RPC handlers to utilize the new fee recommendation feature.

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
wallet/wallet_test.go Updated test wallet creation to pass &testutil.MockSyncer{} to the updated constructor.
wallet/wallet.go Added new broadcasting methods and fee recommendation logic; updated NewSingleAddressWallet signature.
testutil/testutil.go Added the MockSyncer implementation for test usage.
rhp/v4/rpc_test.go Updated wallet instantiation and added tests for the RecommendedFee method.
rhp/v4/rpc.go Replaced direct fee retrieval from TxPool with signer.RecommendedFee in contract-related methods.
.changeset/*.md Added change log notes for the new broadcast methods and fee recommendation changes.

@ChrisSchinnerl ChrisSchinnerl requested a review from n8maninger June 3, 2025 09:22
@n8maninger n8maninger merged commit 6c96f1e into master Jun 3, 2025
11 checks passed
@n8maninger n8maninger deleted the chris/wallet-fee-broadcast branch June 3, 2025 18:03
@github-project-automation github-project-automation bot moved this from In Progress to Done in Sia Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants