rhp4: allow cross-origin requests #253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
This PR enables cross-origin requests for RHP4 by modifying the WebTransport server configuration. The changes include updating the origin check to allow all origins in the QUIC listener and adding a changeset note for documentation.
- Updated CheckOrigin configuration in rhp/v4/quic/quic.go to always allow requests.
- Added a changeset file (.changeset/fixed_rhp4_webtransport_rejecting_cross_origin_connections.md) to document the change.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| rhp/v4/quic/quic.go | Added CheckOrigin callback to allow all origins to connect. |
| .changeset/fixed_rhp4_webtransport_rejecting_cross_origin_connections.md | Documented the cross-origin fix. |
Comments suppressed due to low confidence (1)
rhp/v4/quic/quic.go:196
- Allowing all origins bypasses standard security checks. Please ensure that comprehensive security measures are in place elsewhere in the application to protect against potential cross-origin attacks.
CheckOrigin: func(*http.Request) bool {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.