initial vault #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

n8maninger merged 15 commits into master from init

Mar 26, 2025

Member

n8maninger commented Mar 24, 2025

No description provided.

n8maninger requested review from peterjan, lukechampine and ChrisSchinnerl

March 24, 2025 23:53

n8maninger closed this

n8maninger force-pushed the init branch from 0603a5f to 153366c Compare

March 25, 2025 02:30

n8maninger reopened this

n8maninger changed the base branch from master to nate/siad-mnemonics

March 25, 2025 02:39

lukechampine reviewed

View reviewed changes

vault/vault.go Outdated Show resolved Hide resolved

peterjan reviewed

View reviewed changes

Member

peterjan left a comment

Nothing but nits. This exercise definitely highlights the things we keep reusing all over the place 😅 migrations, config, peer store, sql types, our sql.go file etc

cmd/vaultd/main.go Outdated Show resolved Hide resolved

persist/sqlite/types.go Show resolved Hide resolved

vault/vault.go Outdated Show resolved Hide resolved

api/server.go Show resolved Hide resolved

api/server.go Show resolved Hide resolved

api/server.go Show resolved Hide resolved

api/server.go Show resolved Hide resolved

persist/sqlite/init.sql Outdated Show resolved Hide resolved

persist/sqlite/init.sql Outdated Show resolved Hide resolved

persist/sqlite/init.sql Outdated Show resolved Hide resolved

lukechampine reviewed

View reviewed changes

vault/vault.go Show resolved Hide resolved

lukechampine reviewed

View reviewed changes

vault/vault.go Show resolved Hide resolved

lukechampine reviewed

View reviewed changes

api/types.go Outdated Show resolved Hide resolved

lukechampine reviewed

View reviewed changes

api/types.go Outdated Show resolved Hide resolved

lukechampine reviewed

View reviewed changes

api/types.go Show resolved Hide resolved

Member

lukechampine commented Mar 25, 2025

Is there a reason the repo isn't named vaultd?

ChrisSchinnerl reviewed

View reviewed changes

api/server.go Show resolved Hide resolved

persist/sqlite/init.sql Outdated Show resolved Hide resolved

vault/vault.go Outdated Show resolved Hide resolved

vault/vault.go Outdated Show resolved Hide resolved

n8maninger requested review from peterjan, ChrisSchinnerl and lukechampine

March 25, 2025 15:19

lukechampine reviewed

View reviewed changes

vault/vault.go Outdated Show resolved Hide resolved

n8maninger added 10 commits

March 25, 2025 12:37


          vault: init

e726a96


          api: add api

b5c4df8


          sqlite: add store

61f10df


          initial cmd

851f9e6


          api: fix lint

c86b851


          docker: update Go

df8d1c2


          fix migration test

0c283a6


          address comments

1f7bb95


          sqlite: remove duplicate indice

7777f8b


          sqlite: fix migration test again

47c38be

n8maninger added 5 commits

March 25, 2025 12:37


          seedvault -> vaultd

a56bb45


          remove unused

05d27e8


          add check

411c970


          sqlite: fix migration test again

48c5e95


          oops (again)

n8maninger force-pushed the init branch from 995ed7e to 3586343 Compare

March 25, 2025 19:37

n8maninger changed the base branch from nate/siad-mnemonics to master

March 25, 2025 20:00

peterjan reviewed

View reviewed changes

cmd/vaultd/main.go Show resolved Hide resolved

peterjan approved these changes

View reviewed changes

ChrisSchinnerl approved these changes

View reviewed changes

n8maninger merged commit 0982d9d into master

8 checks passed

n8maninger deleted the init branch

March 26, 2025 09:13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet