fix(renterd): contract timeline current block height#1189
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
🦋 Changeset detectedLatest commit: 3855c96 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the incorrect placement of the current block height indicator in the contract timeline by switching from directly using syncStatus.estimatedBlockHeight to a dedicated currentHeight variable, and updates the memo dependencies accordingly. It also adds a changeset entry for a renterd patch release.
- Replace
syncStatus.estimatedBlockHeightwithcurrentHeightinContractTableContext - Update
useMemodependency array to depend oncurrentHeightinstead ofsyncStatus.estimatedBlockHeight - Add a
.changesetentry for the patch
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| apps/renterd/contexts/contracts/index.tsx | Switched context field to currentHeight and updated useMemo dependencies |
| .changeset/tricky-pillows-smoke.md | Added a patch changeset entry describing the fix for the timeline block height indicator issue |
Comments suppressed due to low confidence (2)
apps/renterd/contexts/contracts/index.tsx:129
- [nitpick] The variable name "currentHeight" is somewhat ambiguous; consider renaming it to "currentBlockHeight" for clarity.
currentHeight,
apps/renterd/contexts/contracts/index.tsx:127
- Consider adding a unit or integration test to verify that the contract timeline correctly renders the current block height indicator using the updated
currentHeightvalue.
const cellContext = useMemo(() => {

Uh oh!
There was an error while loading. Please reload this page.