Skip to content

test(hostd): re-enable integrity check test #1191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2025

Conversation

alexfreska
Copy link
Member

@alexfreska alexfreska commented Jul 16, 2025

  • Test was disabled until integrity checks were updated to support v2.

@Copilot Copilot AI review requested due to automatic review settings July 16, 2025 19:32
Copy link

vercel bot commented Jul 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
explorer ⬜️ Ignored (Inspect) Visit Preview Jul 16, 2025 7:33pm
explorer-zen ⬜️ Ignored (Inspect) Visit Preview Jul 16, 2025 7:33pm
hostd ⬜️ Ignored (Inspect) Visit Preview Jul 16, 2025 7:33pm
renterd ⬜️ Ignored (Inspect) Visit Preview Jul 16, 2025 7:33pm

Copy link

changeset-bot bot commented Jul 16, 2025

⚠️ No Changeset found

Latest commit: 2cda772

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-project-automation github-project-automation bot moved this to In Progress in Sia Jul 16, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR re-enables the previously skipped bulk integrity check test for contracts.

  • Adds the getContractRowsAll import from the fixtures
  • Uncomments and activates the contracts bulk integrity check test block
Comments suppressed due to low confidence (1)

apps/hostd-e2e/src/specs/contracts.spec.ts:10

  • [nitpick] Consider grouping and ordering imports from '../fixtures/contracts' consistently, for example alphabetically: expectVersionMode, getContractRows, getContractRowsAll, setVersionMode.
  getContractRowsAll,

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@alexfreska alexfreska merged commit d9eac50 into main Jul 16, 2025
73 checks passed
@alexfreska alexfreska deleted the test_hostd_re-enable_integrity_check_test branch July 16, 2025 20:40
@github-project-automation github-project-automation bot moved this from In Progress to Done in Sia Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants