refactor(renterd): remove v1 settings and price table columns #1194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1c2cb8e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the renterd host explorer by removing legacy v1 settings and price table columns, consolidating around v2 settings as the primary interface. The changes simplify the codebase by removing deprecated functionality while maintaining the same host data display capabilities.
- Removes v1 price table and host settings column definitions and related types
- Renames v2 settings columns to use "settings_" prefix instead of "v2_"
- Updates default visible columns to use the new naming convention
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| apps/renterd/contexts/hosts/types.tsx | Removes v1 imports and type definitions, renames column types and updates default visible columns |
| apps/renterd/contexts/hosts/dataset.ts | Removes priceTable field assignment from host data structure |
| apps/renterd/contexts/hosts/columns.tsx | Removes all v1 price table and host settings column definitions, renames v2 columns to settings_ prefix |
| .changeset/orange-lines-watch.md | Documents the breaking change removing v1 columns |
Comments suppressed due to low confidence (1)
apps/renterd/contexts/hosts/types.tsx:123
- The type name 'HostTableColumnV2Settings' still contains 'V2' but now refers to 'settingsColumns'. Since the columns have been renamed from v2_ to settings_, this type should be renamed to 'HostTableColumnSettings' for consistency.
export type HostTableColumnV2Settings = typeof settingsColumns[number]
alexfreska
force-pushed
the
refactor_renterd_remove_v1_settings_and_price_table_columns
branch
2 times, most recently
from
c793330 to
b2bc88f
Compare
telestrial
approved these changes
Jul 17, 2025
Merge activity
|
alexfreska
force-pushed
the
refactor_renterd_remove_v1_settings_and_price_table_columns
branch
from
b2bc88f to
1c2cb8e
Compare
alexfreska
deleted the
refactor_renterd_remove_v1_settings_and_price_table_columns
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.