-
Notifications
You must be signed in to change notification settings - Fork 13
ci: add nx cache, run e2e on main #1199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Skipped Deployments
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds Nx caching to GitHub Actions and enables end-to-end tests to run on the main branch in addition to pull requests. The changes improve CI performance through caching and ensure continuous testing on the main branch.
- Adds Nx cache configuration to the JavaScript setup action
- Modifies e2e workflow conditions to run tests on both pull requests and main branch pushes
- Optimizes existing bun cache by removing unnecessary hash components
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
.github/workflows/e2e.yml | Updates job conditions to run e2e tests on main branch pushes in addition to pull requests |
.github/actions/setup-js/action.yml | Adds Nx caching and optimizes existing bun cache configuration |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
fc5c6f1
to
8c70b93
Compare
8c70b93
to
5dda985
Compare
5dda985
to
f47a6e4
Compare
Only the 2 bulk integrity check tests are failing and we cannot upgrade cluster daemons at the moment. |
affected
logic means unchanged apps are already not rebuilt on PR, but they may now load from cache on many steps that build all projects such as on main workflows.if
logic meant e2e shards were skipped."dependsOn": ["sdk:build"]
which has the same effect.