Skip to content

ci: add nx cache, run e2e on main #1199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2025
Merged

Conversation

alexfreska
Copy link
Member

@alexfreska alexfreska commented Jul 18, 2025

CI performance improvements, fixes, and configuration.

  • Pinning daemon versions in e2e tests until they have been fixed in cluster
  • Added nx cache step, this should significantly speed up many builds where large libraries like the design-system are unchanged.
    • Notes: Removed the next cache key as it should not be combined with npm or bun. Not adding a next cache for now, if we do add one it should be a cache and key per project. For now testing how only an nx cache performs, also important to note that affected logic means unchanged apps are already not rebuilt on PR, but they may now load from cache on many steps that build all projects such as on main workflows.
  • e2e shards now run on pushes to main, previously the if logic meant e2e shards were skipped.
  • Removed Force build SDK steps, targets that require the sdk now include "dependsOn": ["sdk:build"] which has the same effect.

@Copilot Copilot AI review requested due to automatic review settings July 18, 2025 13:49
Copy link

vercel bot commented Jul 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
explorer ⬜️ Ignored (Inspect) Visit Preview Jul 18, 2025 5:50pm
explorer-zen ⬜️ Ignored (Inspect) Visit Preview Jul 18, 2025 5:50pm
hostd ⬜️ Ignored (Inspect) Visit Preview Jul 18, 2025 5:50pm
renterd ⬜️ Ignored (Inspect) Visit Preview Jul 18, 2025 5:50pm

Copy link

changeset-bot bot commented Jul 18, 2025

⚠️ No Changeset found

Latest commit: f47a6e4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-project-automation github-project-automation bot moved this to In Progress in Sia Jul 18, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds Nx caching to GitHub Actions and enables end-to-end tests to run on the main branch in addition to pull requests. The changes improve CI performance through caching and ensure continuous testing on the main branch.

  • Adds Nx cache configuration to the JavaScript setup action
  • Modifies e2e workflow conditions to run tests on both pull requests and main branch pushes
  • Optimizes existing bun cache by removing unnecessary hash components

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/e2e.yml Updates job conditions to run e2e tests on main branch pushes in addition to pull requests
.github/actions/setup-js/action.yml Adds Nx caching and optimizes existing bun cache configuration

Copy link
Member Author

alexfreska commented Jul 18, 2025

@alexfreska alexfreska force-pushed the ci_add_nx_cache_run_e2e_on_main branch from 5dda985 to f47a6e4 Compare July 18, 2025 17:44
@alexfreska
Copy link
Member Author

alexfreska commented Jul 18, 2025

Only the 2 bulk integrity check tests are failing and we cannot upgrade cluster daemons at the moment.

@alexfreska alexfreska merged commit 237e8f9 into main Jul 18, 2025
70 of 72 checks passed
@alexfreska alexfreska deleted the ci_add_nx_cache_run_e2e_on_main branch July 18, 2025 18:47
@github-project-automation github-project-automation bot moved this from In Progress to Done in Sia Jul 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants