-
Notifications
You must be signed in to change notification settings - Fork 13
feat(design-system): add hostmap, tailwind merge, other #1228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 76e9c68 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
6ed2df3
to
e61f5d8
Compare
2e08288
to
862e457
Compare
e61f5d8
to
7328bcd
Compare
7328bcd
to
aa4b732
Compare
aa4b732
to
459f46c
Compare
459f46c
to
101098a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds new data visualization components and refactors storage helpers to support v2-only host operations. The main focus is adding a DataTable component with TanStack integration, a HostMap visualization, and improved country handling utilities.
- Refactored storage utilities to work exclusively with V2HostSettings instead of mixed v1/v2 support
- Added TanStack-based DataTable with virtualization, filtering, and pagination
- Added HostMap component for geographical visualization of hosts
- Added country utilities and CountryFlag component for better internationalization
Reviewed Changes
Copilot reviewed 31 out of 33 changed files in this pull request and generated 4 comments.
Show a summary per file
File | Description |
---|---|
libs/units/src/storage.ts | Refactored storage cost calculations to use V2HostSettings exclusively |
libs/units/src/country.ts | Added country utilities and improved error handling for country codes |
libs/design-system/src/app/DataTable/* | New TanStack-based data table implementation with virtualization |
libs/design-system/src/app/HostMap/* | New geographical host visualization component |
libs/design-system/src/components/CountryFlag.tsx | New component for displaying country flags with proper accessibility |
libs/design-system/src/lib/ui.ts | Added tailwind class merging utility function |
Comments suppressed due to low confidence (1)
libs/units/src/storage.spec.ts:30
- The test expects '$8.64/TB' but the function
displayStoragePricePerTBPerMonth
should append '/month' suffix based on theperMonth: true
parameter in the implementation. The expected value should be '$8.64/TB/month'.
).toEqual('$8.64/TB')
b30eb57
to
de78c14
Compare
de78c14
to
ba8ef84
Compare
ba8ef84
to
f1f4814
Compare
f1f4814
to
d091823
Compare
d091823
to
76e9c68
Compare
The PR adds a few components for use in indexd, and also cleans up the units storage helpers used across apps.
design-system
units