Skip to content

Commit 48a7b6c

Browse files
committed
chore: remove manager config
1 parent 15c16a1 commit 48a7b6c

File tree

2 files changed

+11
-31
lines changed

2 files changed

+11
-31
lines changed

cmd/signozschemamigrator/migrate.go

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -73,13 +73,7 @@ func main() {
7373
// the value of this env would replace all occurences of {{.SIGNOZ_CLUSTER}} in the migration files
7474
os.Setenv("SIGNOZ_CLUSTER", clusterName)
7575

76-
managerConfig := migrationmanager.NewConfig(
77-
dsn,
78-
clusterName,
79-
disableDurationSortFeature,
80-
disableTimestampSortFeature,
81-
)
82-
manager, err := migrationmanager.New(managerConfig)
76+
manager, err := migrationmanager.New(dsn, clusterName, disableDurationSortFeature, disableTimestampSortFeature)
8377
if err != nil {
8478
logger.Fatal("Failed to create migration manager", zap.Error(err))
8579
}

migrationManager/manager.go

Lines changed: 10 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -17,40 +17,26 @@ type MigrationManager struct {
1717
logger *zap.Logger
1818
}
1919

20-
type Config struct {
21-
migrators.MigratorConfig
22-
}
23-
24-
func NewConfig(
25-
dsn string,
26-
clusterName string,
27-
isDurationSortFeatureDisabled bool,
28-
isTimestampSortFeatureDisabled bool,
29-
) Config {
30-
return Config{
31-
MigratorConfig: migrators.MigratorConfig{
32-
DSN: dsn,
33-
ClusterName: clusterName,
34-
IsDurationSortFeatureDisabled: isDurationSortFeatureDisabled,
35-
IsTimestampSortFeatureDisabled: isTimestampSortFeatureDisabled,
36-
},
37-
}
38-
}
39-
40-
func New(cfg Config) (*MigrationManager, error) {
20+
func New(dsn string, clusterName string, isDurationSortFeatureDisabled bool, isTimestampSortFeatureDisabled bool) (*MigrationManager, error) {
4121
logger := zap.L().With(zap.String("component", "migrationManager"))
22+
cfg := migrators.MigratorConfig{
23+
DSN: dsn,
24+
ClusterName: clusterName,
25+
IsDurationSortFeatureDisabled: isDurationSortFeatureDisabled,
26+
IsTimestampSortFeatureDisabled: isTimestampSortFeatureDisabled,
27+
}
4228

43-
logsMigrator, err := createNewMigrator("logs", cfg.MigratorConfig)
29+
logsMigrator, err := createNewMigrator("logs", cfg)
4430
if err != nil {
4531
logger.Error("Failed to create logs migrator", zap.Error(err))
4632
return nil, err
4733
}
48-
metricsMigrator, err := createNewMigrator("metrics", cfg.MigratorConfig)
34+
metricsMigrator, err := createNewMigrator("metrics", cfg)
4935
if err != nil {
5036
logger.Error("Failed to create metrics migrator", zap.Error(err))
5137
return nil, err
5238
}
53-
tracesMigrator, err := createNewMigrator("traces", cfg.MigratorConfig)
39+
tracesMigrator, err := createNewMigrator("traces", cfg)
5440
if err != nil {
5541
logger.Error("Failed to create traces migrator", zap.Error(err))
5642
return nil, err

0 commit comments

Comments
 (0)