Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from OpenCensus to OTel API #452

Merged
merged 7 commits into from
Dec 23, 2024
Merged

Move from OpenCensus to OTel API #452

merged 7 commits into from
Dec 23, 2024

Conversation

srikanthccv
Copy link
Member

No description provided.

@srikanthccv srikanthccv marked this pull request as ready for review November 13, 2024 14:04
@nityanandagohain
Copy link
Member

If not urgen't I will delay this review a bit.

Copy link
Member

@nityanandagohain nityanandagohain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good to me apart from the changes done in kafka receiver. Someone with context on that receiver might be better person to review. But unblocking from my side.

exporter/clickhouselogsexporter/exporter.go Show resolved Hide resolved
grandwizard28
grandwizard28 previously approved these changes Dec 17, 2024
@srikanthccv srikanthccv merged commit cc3d7be into main Dec 23, 2024
5 checks passed
@srikanthccv srikanthccv deleted the update-own-metrics branch December 23, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants