Skip to content

Fix/signoz-exporter: added extra attribute #572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 1, 2025
Merged

Conversation

aniketio-ctrl
Copy link
Contributor

Fix -
the same labels and name was generated by the clickhousemetricsexporter so we added one more label to distinguish

@srikanthccv
Copy link
Member

@aniketio-ctrl, please explain how current instrumentation creates an issue and how adding another label with constant value solves it?

@aniketio-ctrl
Copy link
Contributor Author

aniketio-ctrl commented Apr 1, 2025

@aniketio-ctrl, please explain how current instrumentation creates an issue and how adding another label with constant value solves it?

this is because both the exporter is sending same metrics with same label name that what causing the issue, thats why i have added one more label to distinguish

aniket@Anikets-MacBook-Pro-2 bin % curl localhost:8888/metrics | grep exporter_db_write_latency
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 3885 0 3885 0 0 885k 0 --:--:-- --:--:-- --:--:-- 948k

  • collected metric "exporter_db_write_latency" { label:{name:"exporter" value:"metrics"} label:{name:"service_instance_id" value:"6941d912-6255-4621-9b77-af2343856eda"} label:{name:"service_name" value:"/Users/aniket/Library/Caches/JetBrains/GoLand2024.3/tmp/GoLand/___1go_build_github_com_SigNoz_signoz_otel_collector_cmd_signozotelcollector"} label:{name:"service_version" value:"dev"} label:{name:"table" value:"distributed_samples_v4"} histogram:{sample_count:11 sample_sum:83 bucket:{cumulative_count:11 upper_bound:250} bucket:{cumulative_count:11 upper_bound:500} bucket:{cumulative_count:11 upper_bound:750} bucket:{cumulative_count:11 upper_bound:1000} bucket:{cumulative_count:11 upper_bound:2000} bucket:{cumulative_count:11 upper_bound:2500} bucket:{cumulative_count:11 upper_bound:3000} bucket:{cumulative_count:11 upper_bound:4000} bucket:{cumulative_count:11 upper_bound:5000} bucket:{cumulative_count:11 upper_bound:6000} bucket:{cumulative_count:11 upper_bound:8000} bucket:{cumulative_count:11 upper_bound:10000} bucket:{cumulative_count:11 upper_bound:15000} bucket:{cumulative_count:11 upper_bound:25000} bucket:{cumulative_count:11 upper_bound:30000}}} was collected before with the same name and label values
  • collected metric "exporter_db_write_latency" { label:{name:"exporter" value:"metrics"} label:{name:"service_instance_id" value:"6941d912-6255-4621-9b77-af2343856eda"} label:{name:"service_name" value:"/Users/aniket/Library/Caches/JetBrains/GoLand2024.3/tmp/GoLand/___1go_build_github_com_SigNoz_signoz_otel_collector_cmd_signozotelcollector"} label:{name:"service_version" value:"dev"} label:{name:"table" value:"distributed_time_series_v4"} histogram:{sample_count:11 sample_sum:61 bucket:{cumulative_count:11 upper_bound:250} bucket:{cumulative_count:11 upper_bound:500} bucket:{cumulative_count:11 upper_bound:750} bucket:{cumulative_count:11 upper_bound:1000} bucket:{cumulative_count:11 upper_bound:2000} bucket:{cumulative_count:11 upper_bound:2500} bucket:{cumulative_count:11 upper_bound:3000} bucket:{cumulative_count:11 upper_bound:4000} bucket:{cumulative_count:11 upper_bound:5000} bucket:{cumulative_count:11 upper_bound:6000} bucket:{cumulative_count:11 upper_bound:8000} bucket:{cumulative_count:11 upper_bound:10000} bucket:{cumulative_count:11 upper_bound:15000} bucket:{cumulative_count:11 upper_bound:25000} bucket:{cumulative_count:11 upper_bound:30000}}} was collected before with the same name and label values
  • collected metric "exporter_db_write_latency" { label:{name:"exporter" value:"metrics"} label:{name:"service_instance_id" value:"6941d912-6255-4621-9b77-af2343856eda"} label:{name:"service_name" value:"/Users/aniket/Library/Caches/JetBrains/GoLand2024.3/tmp/GoLand/___1go_build_github_com_SigNoz_signoz_otel_collector_cmd_signozotelcollector"} label:{name:"service_version" value:"dev"} label:{name:"table" value:"distributed_exp_hist"} histogram:{sample_count:11 sample_sum:10 bucket:{cumulative_count:11 upper_bound:250} bucket:{cumulative_count:11 upper_bound:500} bucket:{cumulative_count:11 upper_bound:750} bucket:{cumulative_count:11 upper_bound:1000} bucket:{cumulative_count:11 upper_bound:2000} bucket:{cumulative_count:11 upper_bound:2500} bucket:{cumulative_count:11 upper_bound:3000} bucket:{cumulative_count:11 upper_bound:4000} bucket:{cumulative_count:11 upper_bound:5000} bucket:{cumulative_count:11 upper_bound:6000} bucket:{cumulative_count:11 upper_bound:8000} bucket:{cumulative_count:11 upper_bound:10000} bucket:{cumulative_count:11 upper_bound:15000} bucket:{cumulative_count:11 upper_bound:25000} bucket:{cumulative_count:11 upper_bound:30000}}} was collected before with the same name and label values

@srikanthccv
Copy link
Member

Thanks for the explanation. Please fix CI.

@aniketio-ctrl aniketio-ctrl merged commit d654a4a into main Apr 1, 2025
4 checks passed
@aniketio-ctrl aniketio-ctrl deleted the fix/signoz-exporter branch April 1, 2025 08:47
@grandwizard28
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants