Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix(otelcol): remove the v2 metrics exporter configuration (#… …7105)" #7118

Merged
merged 2 commits into from
Feb 15, 2025

Conversation

srikanthccv
Copy link
Member

@srikanthccv srikanthccv commented Feb 15, 2025

Summary

This reverts commit 846b6a9 and updates the collector version.


Important

Reverts a previous commit, updates OpenTelemetry Collector and schema migrator versions, and adds a new metrics exporter configuration.

  • Revert:
    • Reverts commit 846b6a9 which removed the v2 metrics exporter configuration.
  • Version Updates:
    • Updates otel-collector image to signoz/signoz-otel-collector:0.111.28 in docker-compose.ha.yaml and docker-compose.yaml.
    • Updates schema-migrator image to signoz/signoz-schema-migrator:0.111.28 in docker-compose.ha.yaml and docker-compose.yaml.
  • Configuration Changes:
    • Adds signozclickhousemetrics exporter in otel-collector-config.yaml.
    • Updates metrics exporters to include signozclickhousemetrics in otel-collector-config.yaml.

This description was created by Ellipsis for 2a5c9de. It will automatically update as commits are pushed.

@srikanthccv srikanthccv requested a review from a team as a code owner February 15, 2025 09:25
@github-actions github-actions bot added the bug Something isn't working label Feb 15, 2025
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 2a5c9de in 2 minutes and 3 seconds

More details
  • Looked at 160 lines of code in 6 files
  • Skipped 0 files when reviewing.
  • Skipped posting 12 drafted comments based on config settings.
1. deploy/docker-swarm/docker-compose.ha.yaml:227
  • Draft comment:
    Updated otel-collector image version from 0.111.27 to 0.111.28. Confirm that the version bump doesn’t require further config adjustments.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50%
    None
2. deploy/docker-swarm/docker-compose.ha.yaml:250
  • Draft comment:
    Updated schema-migrator image version from 0.111.24 to 0.111.28. Ensure consistency with other deployment files.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50%
    None
3. deploy/docker-swarm/otel-collector-config.yaml:90
  • Draft comment:
    Added 'signozclickhousemetrics' exporter to both metrics and metrics/prometheus pipelines. Verify this is the intended configuration to revert the previous change.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50%
    None
4. deploy/docker/docker-compose.ha.yaml:237
  • Draft comment:
    Updated otel-collector image version from ${OTELCOL_TAG:-0.111.27} to ${OTELCOL_TAG:-0.111.28}. Confirm consistency with related services.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50%
    None
5. deploy/docker/docker-compose.ha.yaml:271
  • Draft comment:
    Updated schema-migrator image version from ${OTELCOL_TAG:-0.111.24} to ${OTELCOL_TAG:-0.111.28}. Verify that downstream dependencies align with this change.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50%
    None
6. deploy/docker/docker-compose.yaml:166
  • Draft comment:
    Updated otel-collector image version to ${OTELCOL_TAG:-0.111.28}. Ensure that other service dependencies remain compatible.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50%
    None
7. deploy/docker/otel-collector-config.yaml:69
  • Draft comment:
    Added 'signozclickhousemetrics' exporter with DSN configuration. Confirm that its inclusion in pipelines is consistent with system expectations.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50%
    None
8. deploy/docker-swarm/docker-compose.ha.yaml:227
  • Draft comment:
    Updated otel-collector image tag to 0.111.28 (and similarly schema-migrator version updated) for consistency across docker-swarm. Ensure all dependent services are compatible with this version.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
    This comment is about updating a dependency version and asks to ensure compatibility with dependent services. According to the rules, comments on dependency changes and asking to ensure compatibility are not allowed.
9. deploy/docker-swarm/otel-collector-config.yaml:67
  • Draft comment:
    Reintroduced the signozclickhousemetrics exporter and appended it to the metrics pipelines. Confirm this duplicate exporter (with clickhousemetricswrite) is intentional and does not cause duplicate metric data.
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 20% vs. threshold = 50%
    The comment asks for confirmation about intention, which violates our rules about not asking authors to confirm things. However, it does point out a potential technical issue with duplicate metric data being exported. But without understanding the full system architecture and the purpose of each exporter, we can't be certain this is actually a problem.
    The duplicate exporters might serve different purposes or handle different metric formats that we can't see from this config alone. The comment might be highlighting a real issue.
    While there could be a real issue, the comment violates our rules by asking for confirmation rather than making a clear statement about what needs to be changed.
    Delete the comment because it asks for confirmation of intention rather than making a clear, actionable statement about what needs to be changed.
10. deploy/docker/docker-compose.ha.yaml:237
  • Draft comment:
    Updated otel-collector and schema-migrator image tags to 0.111.28 in the docker configuration. Verify that this update is consistent with the swarm setup.
  • Reason this comment was not posted:
    Marked as duplicate.
11. deploy/docker/docker-compose.yaml:166
  • Draft comment:
    Updated otel-collector and schema-migrator image tags to 0.111.28 in the docker-compose file. Confirm that volume mounts and dependencies remain correct.
  • Reason this comment was not posted:
    Marked as duplicate.
12. deploy/docker/otel-collector-config.yaml:69
  • Draft comment:
    Re-added the signozclickhousemetrics exporter and included it in both the 'metrics' and 'metrics/prometheus' pipelines. Double-check that merging two exporters for ClickHouse metrics is the desired configuration.
  • Reason this comment was not posted:
    Marked as duplicate.

Workflow ID: wflow_hPsoWAM5jtYcxO2y


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@srikanthccv srikanthccv merged commit e758761 into main Feb 15, 2025
16 of 17 checks passed
@srikanthccv srikanthccv deleted the add-exporter-to-pipeline branch February 15, 2025 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants