chore(install): Improve install script robustness and error handling #9286
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 Summary
This PR improves the robustness and error handling of the installation script (
deploy/install.sh
), making it more compatible with different environments (especially WSL) and providing better user feedback when issues occur.✅ Changes
🏷️ Required: Add Relevant Labels
devops
enhancement
bug
👥 Reviewers
🧪 How to Test
Test on WSL environment:
Test on native Linux:
Test on macOS:
Test error scenarios:
Test docker compose detection:
📋 Checklist
👀 Notes for Reviewers
Key improvements:
WSL Support: The script now properly detects and handles WSL environments, providing clear instructions when Docker Desktop integration is needed.
Better Error Messages: Users will now see helpful error messages instead of cryptic failures, especially for:
Non-blocking Analytics: Analytics events now have a 3-second timeout and won't block the installation if they fail.
Defensive Programming: Added multiple safety checks (directory existence, command availability, etc.) to prevent unexpected failures.
Cleaner Output: Suppressed unnecessary error messages (like
/etc/*-release
not found) that were confusing users.Testing focus areas:
Important
Enhance
deploy/install.sh
for better WSL compatibility, error handling, and Docker checks.realpath
as a fallback forBASE_DIR
detection indeploy/install.sh
.docker compose
.This description was created by
for 27187f5. You can customize this summary. It will automatically update as commits are pushed.