Skip to content

fix: formatted threshold unit in description and summary #9350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: formatted threshold unit in description and summary #9350

wants to merge 1 commit into from
+1 −1

Conversation

aniketio-ctrl
Copy link
Member

📄 Summary

We were formatting the threshold value twice , due to which in the alert description we were getting values incorrect,

✅ Changes

  • Bug fix:

👥 Reviewers

Tag the relevant teams for review:

  • backend

🧪 How to Test

  1. Try testing the Rule with different unit as y axis and threshold unit,
  2. Both the crossed value and threshold value should be in same unit
  3. The value of the threshold and the unit should be same as user described in description

@github-actions github-actions bot added the bug Something isn't working label Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srikanthccv srikanthccv Awaiting requested review from srikanthccv

@therealpandey therealpandey Awaiting requested review from therealpandey therealpandey is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@aniketio-ctrl