-
Notifications
You must be signed in to change notification settings - Fork 1.8k
chore: converted querysearch codemirror component to uncontrolled component #9569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Examples where it breaks with other behaviour changes
- add a filter in list view page of traces service.name = 'frontend' and then switch to time series view
- use the "Share" button we show on the top right of the page and use "Copy page link" to get the sharable URL and open that URL.
They should be caught is dev testing and we should write tests to ensure such problems are caught if we don't have tests already for them.
The above issues are fixed, added tests as well |
Refactor: Convert QuerySearch CodeMirror Component to Uncontrolled
📄 Summary
This PR refactors the
QuerySearchcomponent to use an uncontrolled CodeMirror editor pattern, eliminating local query state management and fixing cursor jumping issues that occurred when the component was controlled.✅ Changes
Refactoring