-
Notifications
You must be signed in to change notification settings - Fork 45.9k
feat(platform/library): Sort agents by "Last Executed" #10353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
feat(platform/library): Sort agents by "Last Executed" #10353
Conversation
…pping improvements
…ring in agent sorting
✅ Deploy Preview for auto-gpt-docs-dev canceled.
|
✅ Deploy Preview for auto-gpt-docs canceled.
|
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
Here's the code health analysis summary for commits Analysis Summary
|
Thanks for contributing this PR to implement the "Last Executed" sort option for agents in the Library! Your PR looks good overall - the implementation includes both frontend and backend changes needed to support this new sorting option, and the scope matches what's described in the title. However, I noticed that while you've outlined a test plan, you haven't checked off the item indicating you've completed testing according to that plan. Could you please:
Specifically, please verify that:
Once you've completed testing and updated the checklist, this PR should be ready for review and merging. Thanks for your contribution! |
Thank you for your contribution! This is a useful addition to the library sorting functionality. The implementation looks good overall, with proper handling of the new sort option in both frontend and backend. I particularly like the dual ordering approach for However, before we can merge this PR, could you please:
Once you've completed the checklist indicating you've verified the functionality, this PR should be ready for final review and merging. |
Thanks for this contribution to improve the agent sorting functionality! The PR looks good overall, but there's one issue before we can merge: Testing CompletionYou've outlined a clear test plan, but it appears you haven't completed the testing yet - the checkboxes in your test plan are still unchecked. Please complete testing according to your plan and mark the checkboxes once verified. Specifically, please test:
Once you've confirmed these items work as expected, please update the PR by checking those boxes. Implementation NotesThe implementation looks solid:
Just complete the testing and we should be good to go! |
This doesn't actually work, because Prisma doesn't support this kind of sorting by attributes of related entities: order_by = [
{"AgentGraph": {"Executions": {"startedAt": "desc"}}}, # this is not supported
{"updatedAt": "desc"},
]
|
Thanks for working on this feature! Adding "Last Executed" sorting to the Library is a valuable improvement. I noticed a few items that need to be addressed before this can be merged:
To move forward:
Looking forward to seeing this feature completed! |
Thanks for your well-structured PR implementing the "Last Executed" sort option for agents in the library! A few notes:
Please update the PR once you've solved the Prisma sorting limitation. You might need to consider alternative approaches like:
Looking forward to the completed implementation! |
e99825a
to
5f6cea2
Compare
I'm re-creating #9871 because it isn't mergeable in its current state and I can't push changes to the author's fork.
Thanks @Keerthi421 for the initial implementation! :)
Changes 🏗️
lastExecuted
as the default sort option in frontend and backendLibrarySortMenu
+useLibrarySortMenu
implementationsTODO:
Checklist 📋
For code changes:
/library