Skip to content

feat(frontend): hide captcha if verified #10397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

0ubbe
Copy link
Contributor

@0ubbe 0ubbe commented Jul 17, 2025

Changes πŸ—οΈ

Do not render the Cloudflare CAPTCHA if the user has already passed verification.

Checklist πŸ“‹

For code changes

  • I have clearly listed my changes in the PR description
  • I have made a test plan
  • I have tested my changes according to the test plan:
    • Try with Cloudflare enabled
    • Shows the CAPTCHA when not verified
    • CAPTCHA is hidden when verified

For configuration changes

None

@0ubbe 0ubbe requested a review from a team as a code owner July 17, 2025 12:07
@0ubbe 0ubbe requested review from Bentlybro and kcze and removed request for a team July 17, 2025 12:07
@github-project-automation github-project-automation bot moved this to πŸ†• Needs initial review in AutoGPT development kanban Jul 17, 2025
Copy link

netlify bot commented Jul 17, 2025

βœ… Deploy Preview for auto-gpt-docs-dev canceled.

Name Link
πŸ”¨ Latest commit 144e956
πŸ” Latest deploy log https://app.netlify.com/projects/auto-gpt-docs-dev/deploys/6879214078de290008dffb2b

@github-actions github-actions bot added the platform/frontend AutoGPT Platform - Front end label Jul 17, 2025
Copy link

netlify bot commented Jul 17, 2025

βœ… Deploy Preview for auto-gpt-docs canceled.

Name Link
πŸ”¨ Latest commit 144e956
πŸ” Latest deploy log https://app.netlify.com/projects/auto-gpt-docs/deploys/68792140128bb90007c5e5c5

Copy link

You are nearing your monthly Qodo Merge usage quota. For more information, please visit here.

PR Reviewer Guide πŸ”

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 πŸ”΅πŸ”΅βšͺβšͺβšͺ
πŸ§ͺΒ No relevant tests
πŸ”’Β No security concerns identified
⚑ Recommended focus areas for review

Logic Error

The condition !turnstile.shouldRender && !turnstile.verified appears incorrect. If shouldRender is false, the CAPTCHA should not render regardless of verification status. The logic should likely be turnstile.shouldRender && !turnstile.verified to show CAPTCHA only when it should render AND user is not verified.

{!turnstile.shouldRender && !turnstile.verified ? (
  <Turnstile
Logic Error

Same logical issue as in login page - the condition !sendEmailTurnstile.shouldRender && !sendEmailTurnstile.verified seems inverted. This would show CAPTCHA when it shouldn't render, which contradicts the intended behavior.

{!sendEmailTurnstile.shouldRender &&
!sendEmailTurnstile.verified ? (
Logic Error

Consistent with other files, the condition !turnstile.shouldRender && !turnstile.verified appears to have inverted logic that would prevent CAPTCHA from showing when it should be displayed for unverified users.

{!turnstile.shouldRender && !turnstile.verified ? (
  <Turnstile

Copy link

deepsource-io bot commented Jul 17, 2025

Here's the code health analysis summary for commits e720f92..144e956. View details on DeepSourceΒ β†—.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScriptβœ…Β SuccessView CheckΒ β†—
DeepSource Python LogoPythonβœ…Β SuccessView CheckΒ β†—

πŸ’‘ If you’re a repository administrator, you can configure the quality gates from the settings.

@github-project-automation github-project-automation bot moved this from πŸ†• Needs initial review to πŸ‘πŸΌ Mergeable in AutoGPT development kanban Jul 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: πŸ‘πŸΌ Mergeable
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants