Skip to content

Conversation

@yashwantbezawada
Copy link

Summary

Fixes issue where agents appear as "Unknown Agent" in the agent activity dropdown.

Root Cause

The buildAgentInfoMap function was only adding agents to the map if they had BOTH graph_id AND id fields populated. Since graph_id is used as the lookup key, agents missing the id field would not be added to the map, causing them to appear as "Unknown Agent".

Changes

Changed the condition in buildAgentInfoMap from:

if (a.graph_id && a.id) {

To:

if (a.graph_id) {

This ensures any agent with a graph_id (the lookup key) will be added to the map. The library_agent_id field remains optional.

Impact

  • All agents with valid graph_id will now appear consistently in the activity dropdown
  • Resolves the "Unknown Agent" issue mentioned in the bug report
  • No breaking changes - library_agent_id is still populated when available

Testing

Manual testing recommended: Verify agents with missing id fields now appear with their proper names instead of "Unknown Agent".

Fixes #11229

…pdown

Previously, agents were only added to the agent info map if they had both
graph_id AND id fields populated. This caused agents missing the id field
to appear as "Unknown Agent" in the activity dropdown.

Changed buildAgentInfoMap to only require graph_id (the lookup key), making
id (library_agent_id) optional. This ensures consistent agent visibility
in the dropdown.

Fixes Significant-Gravitas#11229
@yashwantbezawada yashwantbezawada requested a review from a team as a code owner November 8, 2025 11:09
@yashwantbezawada yashwantbezawada requested review from Pwuts and Swiftyos and removed request for a team November 8, 2025 11:09
@github-project-automation github-project-automation bot moved this to 🆕 Needs initial review in AutoGPT development kanban Nov 8, 2025
@netlify
Copy link

netlify bot commented Nov 8, 2025

Deploy Preview for auto-gpt-docs-dev canceled.

Name Link
🔨 Latest commit 5b1ab57
🔍 Latest deploy log https://app.netlify.com/projects/auto-gpt-docs-dev/deploys/690f25a42dfa5d000831df40

@CLAassistant
Copy link

CLAassistant commented Nov 8, 2025

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the platform/frontend AutoGPT Platform - Front end label Nov 8, 2025
@netlify
Copy link

netlify bot commented Nov 8, 2025

Deploy Preview for auto-gpt-docs canceled.

Name Link
🔨 Latest commit 5b1ab57
🔍 Latest deploy log https://app.netlify.com/projects/auto-gpt-docs/deploys/690f25a4cdf3570008572360

@coderabbitai
Copy link

coderabbitai bot commented Nov 8, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@qodo-merge-pro
Copy link

qodo-merge-pro bot commented Nov 8, 2025

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Data Consistency

Confirm that downstream consumers of the agent map do not rely on the presence of the removed 'id' field and that entries with only 'graph_id' are handled correctly throughout the UI (e.g., selection, deduping, and display logic).

if (a.graph_id) {
  map.set(a.graph_id, {
    name:
      a.name || (a.graph_id ? `Agent ${a.graph_id.slice(0, 8)}` : "Agent"),
    description: a.description || "",
Fallback Name Logic

Validate that the fallback naming using graph_id.slice(0, 8) renders as intended for all graph_id formats (e.g., non-hex or short strings) and does not regress localization or formatting expectations.

name:
  a.name || (a.graph_id ? `Agent ${a.graph_id.slice(0, 8)}` : "Agent"),

@deepsource-io
Copy link

deepsource-io bot commented Nov 8, 2025

Here's the code health analysis summary for commits 8058b94..5b1ab57. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗
DeepSource Python LogoPython✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: 🆕 Needs initial review
Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants