feat(platform): Backend completion of Onboarding tasks #11375

kcze · 2025-11-13T10:28:18Z

Make onboarding task completion backend-authoritative which prevents cheating (previously users could mark all tasks as completed instantly and get rewards) and makes task completion more reliable. Completion of tasks is moved backend with exception of introductory onboarding tasks and visit-page type tasks.

Changes 🏗️

Move incrementing run counter backend and make webhook-triggered and scheduled task execution count as well
Use user timezone for calculating run streak
Frontend task completion is moved from update onboarding state to separate endpoint and guarded so only frontend tasks can be completed
Graph creation, execution and add marketplace agent to library accept source, so appropriate tasks can be completed
Replace client.ts api calls with orval generated and remove no longer used functions from client.ts
Add resolveResponse helper function that unwraps orval generated call result to 2xx response

Small changes&bug fixes:

Make Redis notification bus serialize all payload fields
Fix confetti when group is finished
Collapse finished group when opening Wallet
Play confetti only for tasks that are listed in the Wallet UI

Checklist 📋

For code changes:

I have clearly listed my changes in the PR description
I have made a test plan
I have tested my changes according to the test plan:
- Onboarding can be finished
- All tasks can be finished and work properly
- Confetti works properly

…into kpczerwinski/secrt-1727-onboarding-notifications

…ications

…into kpczerwinski/secrt-1727-onboarding-notifications

github-actions · 2025-11-14T14:33:13Z

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

github-actions · 2025-11-17T02:56:54Z

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

AutoGPT-Agent · 2025-11-17T02:57:58Z

Thanks for implementing the backend support for onboarding tasks! This looks like a solid improvement that will help track and reward user progress automatically.

However, before this PR can be merged, you need to address these issues:

Missing PR Description

Please add a clear description of the changes made in this PR
Complete the checklist in the PR description, particularly the test plan

Technical Implementation

The implementation looks good overall! Here are some observations:

Great work adding the timezone-aware tracking for consecutive run days
Good job handling onboarding notifications and rewards consistently
The automatic milestone tracking will improve the user experience
The serializer fix for notification payloads is a nice catch

Please update the PR description with details about:

The purpose of these changes
Which onboarding steps are now automatically tracked
How the reward system works
Your test plan (how you've verified these changes)

Once you've addressed these documentation issues, this PR should be ready for another review.

AutoGPT-Agent · 2025-11-17T03:15:44Z

Thanks for this PR that improves the security of the onboarding process by moving task completion to the backend!

What looks good

The code changes are well-structured and maintain proper user_id checks
The PR description clearly explains the changes and intent
You've maintained backward compatibility while adding important security improvements
The timezone handling for run streaks is a nice improvement

What needs attention

The PR needs a completed checklist as per our requirements. Please fill out the test plan section and check off the boxes in the PR description. Since this is a significant change touching both backend and frontend, having a clear test plan is important.

Suggested test plan could include:

Testing completion of different types of onboarding tasks (frontend vs backend-controlled)
Verifying timezone-based run streak calculation
Testing that webhook-triggered executions properly count toward run counts
Verifying that task rewards are correctly applied
Testing that frontend can't complete backend-protected tasks

Once you've added and checked off the test plan items, this PR should be good to go!

AutoGPT-Agent · 2025-11-17T11:04:22Z

Thanks for your PR on making onboarding task completion backend-authoritative! The changes look well thought out and should effectively prevent users from cheating by marking all tasks as completed instantly.

I noticed a few items to address before this can be merged:

Your checklist indicates you haven't fully tested that onboarding can be completed from start to finish. This seems like an important test to complete given the significance of the changes to the onboarding flow.
Consider completing all the checkboxes in your test plan to confirm you've verified all aspects of the functionality.
The PR includes a helpful helper function resolveResponse for unwrapping orval generated call results, which improves code readability throughout the frontend changes.
The timezone-aware streak calculation is a nice improvement that will make the feature more reliable for users in different regions.

Once you've completed testing the full onboarding flow and updated your checklist accordingly, this PR should be ready for final review and merging. The code changes themselves look well-structured and maintain proper security patterns with user_id checks.

qodo-merge-pro · 2025-11-17T11:21:56Z

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 4 🔵🔵🔵🔵⚪
🧪 PR contains tests
🔒 No security concerns identified
⚡ Recommended focus areas for review Type Validation The POST /onboarding/step handler validates the 'step' argument using get_args on FrontendOnboardingStep. FastAPI/Orval may coerce values differently; ensure the request body schema strictly restricts values and that invalid enum strings are rejected as intended. async def onboarding_complete_step( user_id: Annotated[str, Security(get_user_id)], step: FrontendOnboardingStep ): if step not in get_args(FrontendOnboardingStep): raise HTTPException(status_code=400, detail="Invalid onboarding step") return await complete_onboarding_step(user_id, step) Concurrency increment_runs reads onboarding then updates counters and computes milestones based on old completedSteps. In concurrent executions, milestones or counters might race. Consider doing the update and step computation in a transaction or re-fetching state after update to avoid duplicate or missed completions. async def increment_runs(user_id: str): """ Increment a user's run counters and trigger any onboarding milestones. """ user_timezone = await _get_user_timezone(user_id) onboarding = await get_user_onboarding(user_id) new_run_count = onboarding.agentRuns + 1 last_run_at, consecutive_run_days = _calculate_consecutive_run_days( onboarding.lastRunAt, onboarding.consecutiveRunDays, user_timezone ) await UserOnboarding.prisma().update( where={"userId": user_id}, data={ "agentRuns": new_run_count, "lastRunAt": last_run_at, "consecutiveRunDays": consecutive_run_days, }, ) milestones = _get_run_milestone_steps(new_run_count, consecutive_run_days) new_steps = [step for step in milestones if step not in onboarding.completedSteps] for step in new_steps: await complete_onboarding_step(user_id, step) Backward Compatibility Notification payload now enforces event type and OnboardingNotificationPayload.step as OnboardingStep and allows extras via model_config. Verify all producers/consumers (WS, Redis serializer) handle this shape and that older clients expecting string step don't break. type: str event: str model_config = pydantic.ConfigDict(extra="allow") class OnboardingNotificationPayload(NotificationPayload): step: OnboardingStep

autogpt_platform/backend/backend/data/onboarding.py

kcze · 2025-11-19T09:04:40Z

autogpt_platform/backend/backend/data/notification_bus.py

+    @field_serializer("payload")
+    def serialize_payload(self, payload: NotificationPayload):
+        """Ensure extra fields survive Redis serialization."""
+        return payload.model_dump()


This makes all fields of NotificationPayload subclasses serialized (in this case OnboardingNotificationPayload)

kcze · 2025-11-19T09:05:17Z

autogpt_platform/backend/backend/data/onboarding.py

+FrontendOnboardingStep = Literal[
+    OnboardingStep.WELCOME,
+    OnboardingStep.USAGE_REASON,
+    OnboardingStep.INTEGRATIONS,
+    OnboardingStep.AGENT_CHOICE,
+    OnboardingStep.AGENT_NEW_RUN,
+    OnboardingStep.AGENT_INPUT,
+    OnboardingStep.CONGRATS,
+    OnboardingStep.MARKETPLACE_VISIT,
+    OnboardingStep.BUILDER_OPEN,
+]


This is a subset of OnboardingStep with only the step that are allowed to be completed frontend-side.

kcze · 2025-11-19T09:05:36Z

autogpt_platform/backend/backend/data/onboarding.py

 async def update_user_onboarding(user_id: str, data: UserOnboardingUpdate):
    update: UserOnboardingUpdateInput = {}
    onboarding = await get_user_onboarding(user_id)
-    if data.completedSteps is not None:


Step completion has now dedicated endpoint.

kcze · 2025-11-19T09:07:53Z

autogpt_platform/backend/backend/server/v2/library/routes_test.py

+    mock_complete_onboarding = mocker.patch(
+        "backend.server.v2.library.routes.agents.complete_onboarding_step",
+        new_callable=AsyncMock,
+    )


This makes sure we don't actually call onboarding function (and try to access db)

kcze · 2025-11-19T09:08:53Z

autogpt_platform/backend/backend/server/model.py

+GraphCreationSource = Literal["builder", "upload"]
+GraphExecutionSource = Literal["builder", "library", "onboarding"]


We need sources to know if an onboarding step should be completed; for example running agent from library shouldn't be completed when running onboarding agent or in the builder.

kcze · 2025-11-19T09:13:05Z

autogpt_platform/backend/backend/data/onboarding.py

 CREDENTIALS_FIELDS: dict[str, str] = get_credentials_blocks()


+def _normalize_datetime(value: datetime | None) -> datetime | None:


The following functions are to calculate run streak for the user for running agent, i.e. keep increasing by one every day and if one day is missed reset. The time is calculated in the user timezone.

github-actions · 2025-11-19T14:06:50Z

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

github-actions · 2025-11-20T02:11:11Z

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

majdyz · 2025-11-20T11:54:12Z

autogpt_platform/backend/backend/data/onboarding.py

+    return get_user_timezone_or_utc(user.timezone if user else None)
+
+
+async def increment_runs(user_id: str):


I don't know how far are we trying to be careful with this,
It's safer to just increment the integer field than do this see Updating Atomic Fields in https://prisma-client-py.readthedocs.io/en/v0.1.0/reference/operations/#integer-fields_1

kcze added 30 commits November 1, 2025 12:41

WebSocket notifications backend

8ec4ec8

Frontend types

f56a3c8

Feedback

f7e57ef

Update types

e38d1c5

Redis notification bus

61c65a5

Merge branch 'kpczerwinski/secrt-1724-websocket-based-notifications' …

9e4e150

…into kpczerwinski/secrt-1727-onboarding-notifications

Confetti on ws notification

e019233

Scroll completed task into view

59d652c

Complete rerun task on Run again

16164d5

Merge branch 'dev' into kpczerwinski/secrt-1724-websocket-based-notif…

49a1c50

…ications

Merge branch 'kpczerwinski/secrt-1724-websocket-based-notifications' …

4fade1c

…into kpczerwinski/secrt-1727-onboarding-notifications

Merge branch 'dev' into kpczerwinski/secrt-1727-onboarding-notifications

614d957

Update endpoints

f520469

Backend SCHEDULE_AGENT

3d48e49

Add resolveResponse helper function

0560e3b

Use postV2AddMarketplaceAgent

4477864

Use getV1OnboardingState

613940b

Use patchV1UpdateOnboardingState

e7915ea

Use postV1CompleteOnboardingStep

55b55f9

Update provider

bb9fed5

Use getV1RecommendedOnboardingAgents

c41e1cd

Use getV1IsOnboardingEnabled

96067cd

Backend increment runs logic

688c784

Backend GET_RESULTS

6e58fa7

Backend MARKETPLACE_ADD_AGENT

c185f28

Backend BUILDER_SAVE_AGENT

0f51a8e

Track source of execution

f938e4d

Backend RE_RUN_AGENT

7f3efd9

Merge branch 'dev' into kpczerwinski/secrt-1726-move-completion-backend

201cf9c

Merge branch 'dev' into kpczerwinski/secrt-1726-move-completion-backend

85f0429

kcze added 2 commits November 17, 2025 11:32

Fixes

154135f

Merge branch 'dev' into kpczerwinski/secrt-1726-move-completion-backend

64ef19f

github-actions bot removed the conflicts Automatically applied to PRs with merge conflicts label Nov 17, 2025

Fix

05866d0

kcze requested review from 0ubbe, Pwuts and majdyz November 17, 2025 11:21

kcze marked this pull request as ready for review November 17, 2025 11:21

kcze requested a review from a team as a code owner November 17, 2025 11:21

qodo-merge-pro bot added the Review effort 4/5 label Nov 17, 2025

sentry bot reviewed Nov 17, 2025

View reviewed changes

autogpt_platform/backend/backend/data/onboarding.py Outdated Show resolved Hide resolved

kcze added 2 commits November 18, 2025 18:48

Merge branch 'dev' into kpczerwinski/secrt-1726-move-completion-backend

3ceec80

Fix openapi schema

ab3d325

kcze commented Nov 19, 2025

View reviewed changes

github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Nov 19, 2025

kcze added 3 commits November 20, 2025 11:09

Remove duplicated call

49e8afc

Merge branch 'dev' into kpczerwinski/secrt-1726-move-completion-backend

8c4899b

Format

db1abb1

github-actions bot removed the conflicts Automatically applied to PRs with merge conflicts label Nov 20, 2025

Move UserOnboarding to model.py

63384a8

majdyz approved these changes Nov 20, 2025

View reviewed changes

github-project-automation bot moved this from 🆕 Needs initial review to 👍🏼 Mergeable in AutoGPT development kanban Nov 20, 2025

		GraphCreationSource = Literal["builder", "upload"]
		GraphExecutionSource = Literal["builder", "library", "onboarding"]

		CREDENTIALS_FIELDS: dict[str, str] = get_credentials_blocks()


		def _normalize_datetime(value: datetime \| None) -> datetime \| None:

		return get_user_timezone_or_utc(user.timezone if user else None)


		async def increment_runs(user_id: str):

feat(platform): Backend completion of Onboarding tasks #11375

Are you sure you want to change the base?

feat(platform): Backend completion of Onboarding tasks #11375

Conversation

kcze commented Nov 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes 🏗️

Checklist 📋

For code changes:

Uh oh!

github-actions bot commented Nov 14, 2025

Uh oh!

github-actions bot commented Nov 17, 2025

Uh oh!

AutoGPT-Agent commented Nov 17, 2025

Missing PR Description

Technical Implementation

Uh oh!

AutoGPT-Agent commented Nov 17, 2025

What looks good

What needs attention

Uh oh!

AutoGPT-Agent commented Nov 17, 2025

Uh oh!

qodo-merge-pro bot commented Nov 17, 2025

PR Reviewer Guide 🔍

Uh oh!

Uh oh!

kcze Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

kcze Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

kcze Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

kcze Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

kcze Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

kcze Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Nov 19, 2025

Uh oh!

github-actions bot commented Nov 20, 2025

Uh oh!

majdyz Nov 20, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

kcze commented Nov 13, 2025 •

edited

Loading