GH-47: Add fail safe to tx queue#47
Open
silabs-borisl wants to merge 2 commits intoSiliconLabs:mainfrom
Open
Conversation
This should prevent a faulty frame to block all the tx queue by itself. Forwarded: SiliconLabs#47 Bug-SiliconLabs: UIC-3335 Bug-Github: SiliconLabs#47
silabs-borisl
force-pushed
the
GH-48/UIC-3335
branch
from
728d5d9 to
853ef58
Compare
silabs-borisl
changed the title
rzr
reviewed
Sep 19, 2024
Co-authored-by: Phil Coval <[email protected]>
|
@silabs-borisl is this patch going to be applied to the main release? |
Collaborator
|
Yes expect this release in spring 2025, I will rebase it on release (and close) Bug-SiliconLabs: UIC-3335 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
It has been observed that in some cases a transmitted frame can block the whole tx queue, blocking any other Z-Wave command.
Now when the tx queue is full instead of waiting for it to resolve itself, we discard the first frame in queue and try to recover from there.
Checklist