Friction compensation #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EtienneAr
requested changes
Feb 10, 2025
|
All fixes done, let me know what you think |
EtienneAr
requested changes
Feb 12, 2025
|
I've fixed the python example and the friction test. We should be good now. |
edantec
force-pushed
the
topic/friction
branch
from
a863bc9 to
75f0d7f
Compare
|
I have added back the throw exception because assert didn't warn us if the vectors have the right size (and this is dangerous). |
EtienneAr
reviewed
Feb 13, 2025
EtienneAr
requested changes
Feb 13, 2025
|
computeFriction now uses a proxy in python bindings. Note that in Python the torque vector provided in argument is still modified (so it is equal to the returned torque). |
EtienneAr
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.