Skip to content

Change likes to reactions... #8187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 126 commits into
base: release-3.0
Choose a base branch
from

Conversation

Oldiesmann
Copy link
Contributor

@Oldiesmann Oldiesmann commented Apr 27, 2024

This PR changes SMF's likes feature into a full-fledged reactions system.

Features:
Admins can add/remove reactions as desired (only limit is defined by the limits of the SMALLINT data type, which should be plenty)
For simplicity, it will use images in a reactions folder in the theme's images folder and will look for a $txt['react_{name}'] string for i18n (defaults to 'name' defined in the database if not found)

Work done so far:

  • Database changes for install and upgrade
  • Modified language strings

Still to do:

  • Code modifications/additions to handle things
  • Theme stuff
  • Testing (this is alpha so not too worried about that yet)

Note that the upgrade uses a combination of db API functions and upgrade_query. In some situations (such as creating a table), upgrade_query is far simpler than the associated db API call.

@Oldiesmann Oldiesmann changed the title Initial commit to change likes to reactions... Change likes to reactions... Apr 29, 2024
@Oldiesmann
Copy link
Contributor Author

Also cc @Sesquipedalian since this will require changes to the DB schema stuff in #8093

@asmith20002
Copy link
Contributor

Good job. IMO this also should be done for 2.1

@live627
Copy link
Contributor

live627 commented May 6, 2024 via email

Oldiesmann and others added 22 commits December 23, 2024 23:14
@Sesquipedalian
Copy link
Member

This is still marked as a draft, @Oldiesmann. Is it ready for review?

@Oldiesmann
Copy link
Contributor Author

Not yet. The back end stuff is done but I haven't done anything on the user side yet because theme-related stuff isn't my strong point. It's at a point now where the admin can add, remove and modify reactions as well as choose who can react to things, but I don't have any of the UI stuff done - the part that actually allows someone to react to something.

@jdarwood007
Copy link
Member

I would suggest putting something in that looks decent and letting the theme PR take care of improving it then.

@Oldiesmann
Copy link
Contributor Author

I would suggest putting something in that looks decent and letting the theme PR take care of improving it then.

@tyrsson is going to help me out with the UI part when he gets a chance.

@tyrsson
Copy link
Collaborator

tyrsson commented Apr 4, 2025

I would suggest putting something in that looks decent and letting the theme PR take care of improving it then.

@tyrsson is going to help me out with the UI part when he gets a chance.

I hope to get started on it in the next couple weeks. It's on the schedule. The markup really is not the part that will take some doing it will be the JS required to make it really usable that needs sorting out.

@Oldiesmann
Copy link
Contributor Author

@DiegoAndresCortes did you mean to request changes? If so, what do you suggest? GitHub only says that you "requested changes with read-only permissions"

@DiegoAndresCortes
Copy link
Member

No recently, only the two older ones where you commented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants