-
Notifications
You must be signed in to change notification settings - Fork 258
Change likes to reactions... #8187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-3.0
Are you sure you want to change the base?
Conversation
Also cc @Sesquipedalian since this will require changes to the DB schema stuff in #8093 |
Good job. IMO this also should be done for 2.1 |
2.1 is feature frozen and receives bug fixes only.
…On Sun, May 5, 2024 at 9:52 PM asmith20002 ***@***.***> wrote:
Good job. IMO this also should be done for 2.1
—
Reply to this email directly, view it on GitHub
<#8187 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADJNN5J44LLS3XBZI3OVHLZA4EAPAVCNFSM6AAAAABG3Y3IX6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJVGE4TIOJXGA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
latest upstream changes
Signed-off-by: Michael Eshom <[email protected]>
…r it was there at one time...
Signed-off-by: Michael Eshom <[email protected]>
This is still marked as a draft, @Oldiesmann. Is it ready for review? |
Not yet. The back end stuff is done but I haven't done anything on the user side yet because theme-related stuff isn't my strong point. It's at a point now where the admin can add, remove and modify reactions as well as choose who can react to things, but I don't have any of the UI stuff done - the part that actually allows someone to react to something. |
I would suggest putting something in that looks decent and letting the theme PR take care of improving it then. |
@tyrsson is going to help me out with the UI part when he gets a chance. |
I hope to get started on it in the next couple weeks. It's on the schedule. The markup really is not the part that will take some doing it will be the JS required to make it really usable that needs sorting out. |
@DiegoAndresCortes did you mean to request changes? If so, what do you suggest? GitHub only says that you "requested changes with read-only permissions" |
No recently, only the two older ones where you commented |
This PR changes SMF's likes feature into a full-fledged reactions system.
Features:
Admins can add/remove reactions as desired (only limit is defined by the limits of the SMALLINT data type, which should be plenty)
For simplicity, it will use images in a reactions folder in the theme's images folder and will look for a $txt['react_{name}'] string for i18n (defaults to 'name' defined in the database if not found)
Work done so far:
Still to do:
Note that the upgrade uses a combination of db API functions and upgrade_query. In some situations (such as creating a table), upgrade_query is far simpler than the associated db API call.