Skip to content

[2.1] Accepts wildcards in email-based ban triggers #8575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Sesquipedalian
Copy link
Member

Fixes #8571 for 2.1

@Sesquipedalian Sesquipedalian added this to the 2.1.5 milestone Apr 12, 2025
@Sesquipedalian Sesquipedalian changed the title Accepts wildcards in email-based ban triggers [2.1] Accepts wildcards in email-based ban triggers Apr 12, 2025
@Sesquipedalian Sesquipedalian requested review from jdarwood007 and removed request for jdarwood007 April 12, 2025 21:28
Copy link
Member

@jdarwood007 jdarwood007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expected this was going to be the fix. I suspect we did type of email to try to validate, but it doesn't work well for bans since we need to introduce wildcards.

For 3.0, I was thinking we could try to use the pattern syntax, but hadn't tested it: https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Attributes/pattern

@Sesquipedalian Sesquipedalian merged commit 143b3a7 into SimpleMachines:release-2.1 Apr 13, 2025
8 checks passed
@Sesquipedalian Sesquipedalian deleted the 2.1/ban_email branch April 13, 2025 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants