Skip to content

Fixed https uri validation #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Fixed https uri validation #484

merged 1 commit into from
Oct 2, 2024

Conversation

sc-ivanlieckens
Copy link
Collaborator

Description / Motivation

Fixed validation of https links

Currently valid values are not being accepted

How Has This Been Tested?

Manual UI test

Local Docker

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the Contributing guide.
  • My code/comments/docs fully adhere to the Code of Conduct.
  • My change is a code change.
  • My change is a documentation change and there are NO other updates required.

@sc-ivanlieckens sc-ivanlieckens added bug Something isn't working MVP Site labels Oct 1, 2024
@sc-ivanlieckens sc-ivanlieckens self-assigned this Oct 1, 2024
@robearlam robearlam merged commit 08a5a18 into main Oct 2, 2024
3 checks passed
@robearlam robearlam deleted the fix/https-validation-fix branch October 2, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working MVP Site
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants