When decoding a compressed TIFF, truncate a too-long string instead of throwing an exception#2986
Merged
JimBobSquarePants merged 4 commits intoSixLabors:mainfrom Sep 29, 2025
Merged
Conversation
4 tasks
Collaborator
|
@brianberns Thanks for the contribution. Could you add one unit test for this case? A test case would look like this: This should go into Formats/Tiff/TiffDecoderTests.cs Then you need to add the example image with the issue into tests\Images\Input\Tiff\Issues\Issue2983.tiff The final thing you need to do is add the image to the Tiff section in TestImages.cs, for example in line 1167:
|
Contributor
Author
|
Done. I added the unit test and confirmed that it passes. However, I'm not very experienced with pull requests, so let me know if there are any problems. |
JimBobSquarePants
approved these changes
Sep 29, 2025
Member
JimBobSquarePants
left a comment
There was a problem hiding this comment.
These changes make sense to me. Thanks for your contribution. Much appreciated!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
This is a proposed fix for #2983. The idea is to truncate a too-long string, rather than throw an exception. This allows ImageSharp to successfully load some problematic TIFF files.