FAI-2420 FAI-2409 FAI-2620 View Application in Recruit #2251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced new classes for querying and managing employment locations. - Updated `WhenHandlingApplyCommand.cs` to include `LocationDto` creation. - Enhanced `ApplyCommandHandler.cs` to handle additional questions and data. - Created `EmploymentLocationsController.cs` for handling HTTP requests. - Defined API request/response structures for employment locations. Changes made by Balaji Jambulingam
- Add new test cases for `ApplyCommandHandler` in `WhenHandlingApplyCommand.cs`. - Improve address handling logic in `ApplyCommandHandler.cs`. - Introduce `IsEmploymentLocationComplete` in `PutApplicationApiRequest.cs`. - Change `Addresses` initialization to an empty list in `LocationDto.cs`. - Ensure proper null handling for addresses to prevent exceptions. Changes made by Balaji Jambulingam
- Implemented a new POST method in EmploymentLocationsController. - Updated EmploymentLocation properties to be nullable in response models. - Introduced UpdateEmploymentLocationsCommand and its handler. - Added PutUpsertEmploymentLocationsApiRequest/Response classes. - Enhanced unit tests for new command and controller methods. Changes made by Balaji Jambulingam
- Added a test to verify NotFound response for null query result. - Changed EmploymentLocationsController to inherit from ControllerBase. - Updated Get method to return NotFound if mediator result is null. - Modified EmploymentLocation property to be non-required in requests. - Aligned code with ASP.NET Core API conventions. Changes made by Balaji Jambulingam
- Introduced a unit test to check for NotFound response when query is null. - Updated EmploymentLocationsController to inherit from ControllerBase. - Emphasized null check in the Get method for better clarity. - Utilized Moq for mocking dependencies in the new test. - Ensured adherence to ASP.NET Core best practices. Changes made by Balaji Jambulingam
- Simplified `IsSectionCompleted` logic in employment locations test. - Removed redundant assertions in `WhenHandlingGetIndexQuery`. - Updated null-checking syntax for `EmploymentLocation` in handlers. - Added `EmploymentLocationStatus` to `GetApplicationByReferenceApiResponse`. - Initialized `Applications` list in `GetApplicationsApiResponse` to avoid null. Changes made by Balaji Jambulingam
- Enhance ApplyCommandHandler to handle null or empty addresses. - Introduce OrderByCity method in AddressExtensions for sorting. - Update EmploymentLocation condition for improved clarity. - Add unit tests for OrderByCity to ensure correct functionality. - Ensure handling of empty and null address lists in tests. Changes made by Balaji Jambulingam
…ations_ML FAI-2403 Choose ML Locations App
…cations_ML FAI-2404 Create the summary of locations you are applying for page
- Added `Expired` status to `ApplicationStatus` enum. - Updated `SubmitApplicationCommandHandler` for better validation. - Introduced `ApplicationsController` to handle application requests. - Created `GetAllApplicationsByIdApiRequest` for fetching applications. - Added tests for `ApplicationsController` to ensure correct behavior. Changes made by Balaji Jambulingam
- Added `Newtonsoft.Json` for address serialization in `ApplyCommandHandler.cs`. - Modified `WhenHandlingGetApplicationsByIdQuery` to use a new `ApiResponse`. - Updated unit tests to use `[Greedy]` for handler dependency resolution. - Removed default initialization of `Addresses` in `Location` class. - Enhanced `GetAllApplicationsByIdApiResponse` with new properties. Changes made by Balaji Jambulingam
…eck_Your_Answers_Page
- Introduced `EmploymentLocation` to `GetApplicationViewApiResponse`. - Added `EmploymentLocation` to `GetApplicationViewQueryResult`. - Created `EmploymentLocationSection` record with implicit conversion. - Updated `GetApplicationViewQueryHandler` to populate new property. - Added necessary using directives for shared API components. Changes made by Balaji Jambulingam
- Introduced `IsSelected` property of type `bool` to `Address`. - Property uses `init` accessor for controlled initialization. - Enhances the functionality of the `Address` class. - Improves state management for address selection. - Aligns with domain requirements for recruitment. Changes made by Balaji Jambulingam
- Introduced `FullAddress` property for address details. - Added `IsSelected` property to indicate selection status. - Included `AddressOrder` property for sorting addresses. - All new properties use the `init` accessor for immutability. - Enhances the API response structure for better data handling. Changes made by Balaji Jambulingam
…ck_Your_Answers_Page FAI-2405 update check your answers page
✨ Refactor application query handling in recruitment API - Restructured classes to use `record` types for better immutability. - Improved handling of application reviews and candidate data. - Enhanced API request/response structures for modern C# practices. - Added new test cases and modified existing ones for updated methods. - Removed unnecessary using directives to clean up the codebase. Changes made by Balaji Jambulingam
Base automatically changed from
FAI-2618_Sharing_Applications_Updating_Rctv2
to
master
June 19, 2025 12:03
✨ Add endpoint to retrieve application review by ID - Introduced a new `Get` method in `ApplicationReviewsController`. - Implemented `GetApplicationReviewByIdQuery` and its handler. - Added unit tests in `WhenGettingApplicationReviewById` for the new endpoint. - Created supporting classes: `GetApplicationReviewByIdQueryResult`, `GetApplicationReviewByIdApiRequest`, and `GetApplicationReviewByIdApiResponse`. - Updated existing tests to cover new functionality. Changes made by Balaji Jambulingam
…lication_Form FAI-2409 Update Application form in RAA with locations applied. Keeping it as one branch, as it would help testing
balaji-j
changed the title
balaji-j
changed the title
- Modified route attribute for the method to be more explicit.
- Changed route from "{vacancyReference:long}" to "vacancyReference/{vacancyReference:long}".
- Improved URL clarity for better API usability.
- Ensured consistency in route formatting across the controller.
Changes made by Balaji Jambulingam
- Added `?includeDetail=true` to `GetUrl` in API request classes. - Introduced new properties in `Application` for status tracking and details. - Replaced `Address` with `EmploymentAddress` in `Location` record. - Added new records for `AdditionalQuestion`, `Qualification`, and more. - Updated `Candidate` record to include optional `PhoneNumber` property. Changes made by Balaji Jambulingam
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.