Skip to content

Flp 1183 learning api endpoint update #2253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Flp 1183 learning api endpoint update #2253

wants to merge 10 commits into from

Conversation

chrisfoster76
Copy link
Contributor

No description provided.

tom-gough
tom-gough requested changes Jun 25, 2025
View reviewed changes
src/Shared/SFA.DAS.SharedOuterApi/InnerApi/Requests/Apprenticeships/GetLearningPriceRequest.cs Outdated
using System;
using SFA.DAS.SharedOuterApi.Interfaces;

namespace SFA.DAS.SharedOuterApi.InnerApi.Requests.Apprenticeships
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This namespace could be updated since it now contains Learning specific requests?

...ared/SFA.DAS.SharedOuterApi/InnerApi/Requests/Apprenticeships/GetLearningStartDateRequest.cs Outdated
using System;
using SFA.DAS.SharedOuterApi.Interfaces;

namespace SFA.DAS.SharedOuterApi.InnerApi.Requests.Apprenticeships
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as above

src/Shared/SFA.DAS.SharedOuterApi/InnerApi/Requests/Apprenticeships/GetLearningsRequest.cs Outdated
@@ -2,7 +2,7 @@

namespace SFA.DAS.SharedOuterApi.InnerApi.Requests.Apprenticeships;

public class GetApprenticeshipsRequest : IGetApiRequest
public class GetLearningsRequest : IGetApiRequest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as above

src/Shared/SFA.DAS.SharedOuterApi/InnerApi/Requests/Apprenticeships/GetPaymentStatusRequest.cs Outdated
@@ -5,11 +5,11 @@ namespace SFA.DAS.SharedOuterApi.InnerApi.Requests.Apprenticeships;

public class GetPaymentStatusRequest : IGetApiRequest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as above

...Shared/SFA.DAS.SharedOuterApi/InnerApi/Responses/Apprenticeships/GetLearningPriceResponse.cs Outdated
@@ -2,7 +2,7 @@

namespace SFA.DAS.SharedOuterApi.InnerApi.Responses.Apprenticeships
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same for responses, won't comment individually on the rest

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed for 'das-apim-endpoints-ApprenticeshipsManage'

Failed conditions
2.7% Coverage on New Code (required ≥ 80%)
10.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed for 'das-apim-endpoints-Apprenticeships'

Failed conditions
65.1% Coverage on New Code (required ≥ 80%)
10.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed for 'das-apim-endpoints-Funding'

Failed conditions
6.4% Coverage on New Code (required ≥ 80%)
10.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed for 'das-apim-endpoints-Earnings'

Failed conditions
22.3% Coverage on New Code (required ≥ 80%)
9.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed for 'das-apim-endpoints-Approvals'

Failed conditions
10.0% Duplication on New Code (required ≤ 5%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tom-gough tom-gough tom-gough approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrisfoster76 @tom-gough