Skip to content

FAI-2600 Show Vacancy closed screen when Application form is being drafted #2255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

balaji-j
Copy link
Contributor

✨ Enhance vacancy response models and refactor queries

  • Added ClosingDate, ClosedDate, VacancyTitle, and EmployerName to response models for better data representation.
  • Updated tests in WhenGettingIndex, WhenGettingSummary, and WhenHandlingGetApplicationQuery to assert new properties.
  • Introduced IVacancyService in query handlers to streamline vacancy detail retrieval.
  • Refactored code to remove unnecessary dependencies and improve readability.
  • Overall improvements enhance application functionality and code structure.

Changes made by Balaji Jambulingam

✨ Enhance vacancy response models and refactor queries

- Added ClosingDate, ClosedDate, VacancyTitle, and EmployerName
  to response models for better data representation.
- Updated tests in WhenGettingIndex, WhenGettingSummary,
  and WhenHandlingGetApplicationQuery to assert new properties.
- Introduced IVacancyService in query handlers to streamline
  vacancy detail retrieval.
- Refactored code to remove unnecessary dependencies and
  improve readability.
- Overall improvements enhance application functionality and
  code structure.

Changes made by Balaji Jambulingam
@balaji-j balaji-j requested a review from dashton82 June 23, 2025 22:42
Copy link

sonarqubecloud bot commented Jul 1, 2025

Quality Gate Passed Quality Gate passed for 'das-apim-endpoints-FindAnApprenticeship'

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
94.5% Coverage on New Code
2.6% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants