FAI-2553 Improvements to the V2 Response #2274
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Excluded `Address` and `OtherAddresses` in mapping logic. - Added null handling test for `Vacancy` in response mapping. - Enhanced `GetVacanciesListResponseItemV2` with new properties and validation. - Improved parsing for `VacancyReference` and `Ukprn` for safety. - Simplified address handling and national vacancy logic in responses. Changes made by Balaji Jambulingam
|
dashton82
approved these changes
Jul 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Update vacancy response models and mappings
AddressandOtherAddressesin mapping logic.Vacancyin response mapping.GetVacanciesListResponseItemV2with new properties and validation.VacancyReferenceandUkprnfor safety.Changes made by Balaji Jambulingam