Csp 2077 delete location endpoint #2277
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkFCain
force-pushed
the
CSP-2077-DeleteLocationEndpoint
branch
from
042fac2 to
f7b3a3e
Compare
MarkFCain
force-pushed
the
CSP-2077-DeleteLocationEndpoint
branch
from
8af530b to
024e05a
Compare
DevenKShah
requested changes
Jul 10, 2025
| namespace SFA.DAS.RoatpCourseManagement.Api.Controllers; | ||
|
|
||
| [ApiController] | ||
| [Route("providers/{ukprn}/locations/{id}/delete")] |
There was a problem hiding this comment.
I think we should be using DELETE verb instead of having delete in the url
|
DevenKShah
reviewed
Jul 11, 2025
| public class ProviderLocationDeleteController(ILogger<ProviderLocationDeleteController> logger, IMediator mediator) : ControllerBase | ||
| { | ||
| [HttpDelete] | ||
| public async Task<IActionResult> DeleteProviderLocation([FromRoute] int ukprn, [FromRoute] Guid id, DeleteProviderLocationCommand command) |
There was a problem hiding this comment.
Adding command here gives wrong impression of adding ukprn and location id in to the body. Use a model instead with the properties that you need and then create a command in the action.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.