Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apr 1152 store not required rules #532

Open
wants to merge 35 commits into
base: master
Choose a base branch
from
Open

Apr 1152 store not required rules #532

wants to merge 35 commits into from

Conversation

David-B-Read
Copy link
Contributor

No description provided.

MarkFCain
MarkFCain reviewed Apr 28, 2020
View reviewed changes
Copy link
Contributor

@MarkFCain MarkFCain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a bit of test coverage needed

@David-B-Read David-B-Read requested a review from MarkFCain April 28, 2020 13:40
MarkFCain
MarkFCain previously approved these changes Apr 28, 2020
View reviewed changes
Base automatically changed from APR-1356_task_list_view_model_tech_debt to master August 17, 2020 16:16
@martin-lush martin-lush dismissed MarkFCain’s stale review August 17, 2020 16:16

The base branch was changed.

martin-lush
martin-lush previously approved these changes Aug 21, 2020
View reviewed changes
MarkFCain and others added 12 commits August 27, 2020 10:37
MarkFCain
MarkFCain previously approved these changes Sep 14, 2020
View reviewed changes
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_265) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martin-lush martin-lush martin-lush left review comments

@MarkFCain MarkFCain MarkFCain left review comments

@alandburns alandburns Awaiting requested review from alandburns

@ChrisJWoodcock ChrisJWoodcock Awaiting requested review from ChrisJWoodcock

@DannyGB DannyGB Awaiting requested review from DannyGB

@gdbarnes gdbarnes Awaiting requested review from gdbarnes

@MichaelYoung1981 MichaelYoung1981 Awaiting requested review from MichaelYoung1981

@chrisfoster76 chrisfoster76 Awaiting requested review from chrisfoster76

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Do Not Merge Not Ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@David-B-Read @MarkFCain @martin-lush @chrisfoster76