Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve reliability of order of config nodes after update #7700

Merged
merged 7 commits into from
Apr 1, 2025

Conversation

Efnilite
Copy link
Member

@Efnilite Efnilite commented Mar 14, 2025

Description

Improves the reliability of the updating order of the config nodes

  • Fixes #getPathSteps() for nodes with no key returning an empty path
  • Makes void nodes differentiable by index of their parent instead of just their parent, allowing multiple void nodes to be added to a parent during an update
  • Fixes #add(int, Node) erroring if adding a node at the last index from the same parent

Target Minecraft Versions: any
Requirements: none
Related Issues: #7533

@Efnilite Efnilite added the bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. label Mar 14, 2025
@sovdeeth sovdeeth requested a review from a team as a code owner March 22, 2025 17:34
@sovdeeth sovdeeth requested review from UnderscoreTud and removed request for a team March 22, 2025 17:34
@Efnilite Efnilite requested a review from a team as a code owner April 1, 2025 21:09
@Efnilite Efnilite requested review from Pikachu920 and removed request for a team April 1, 2025 21:09
@Efnilite Efnilite merged commit fda1521 into dev/patch Apr 1, 2025
5 checks passed
@APickledWalrus APickledWalrus deleted the patch/config-update-order branch April 1, 2025 21:15
APickledWalrus added a commit that referenced this pull request Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants