-
-
Notifications
You must be signed in to change notification settings - Fork 158
the hud thing idk #1506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
viciscat
wants to merge
124
commits into
SkyblockerMod:master
Choose a base branch
from
viciscat:oh-boy
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
the hud thing idk #1506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/SkyblockCraftingRecipeResults.java Co-authored-by: Yasin <[email protected]>
# Conflicts: # src/main/java/de/hysky/skyblocker/skyblock/tabhud/widget/HudWidget.java
# Conflicts: # src/main/java/de/hysky/skyblocker/compatibility/ResourcePackCompatibility.java # src/main/java/de/hysky/skyblocker/config/categories/FarmingCategory.java # src/main/java/de/hysky/skyblocker/config/categories/HelperCategory.java # src/main/java/de/hysky/skyblocker/config/categories/MiningCategory.java # src/main/java/de/hysky/skyblocker/config/categories/OtherLocationsCategory.java # src/main/java/de/hysky/skyblocker/config/categories/SlayersCategory.java # src/main/java/de/hysky/skyblocker/config/categories/UIAndVisualsCategory.java # src/main/java/de/hysky/skyblocker/skyblock/itemlist/recipebook/SkyblockRecipeResults.java # src/main/java/de/hysky/skyblocker/skyblock/tabhud/screenbuilder/WidgetManager.java
Alex33856
reviewed
Jul 17, 2025
src/main/java/de/hysky/skyblocker/config/categories/GeneralCategory.java
Outdated
Show resolved
Hide resolved
# Conflicts: # src/main/java/de/hysky/skyblocker/skyblock/fishing/FishingHudWidget.java
# Conflicts: # src/main/java/de/hysky/skyblocker/skyblock/ItemPickupWidget.java # src/main/java/de/hysky/skyblocker/skyblock/tabhud/widget/ComponentBasedWidget.java
# Conflicts: # src/main/java/de/hysky/skyblocker/mixins/ClientPlayNetworkHandlerMixin.java # src/main/java/de/hysky/skyblocker/skyblock/end/EndHudWidget.java # src/main/java/de/hysky/skyblocker/skyblock/galatea/TreeBreakProgressHud.java # src/main/java/de/hysky/skyblocker/skyblock/tabhud/config/WidgetsConfigurationScreen.java # src/main/java/de/hysky/skyblocker/skyblock/tabhud/config/WidgetsElementList.java # src/main/java/de/hysky/skyblocker/skyblock/tabhud/config/entries/WidgetEntry.java # src/main/java/de/hysky/skyblocker/skyblock/tabhud/config/preview/PreviewTab.java # src/main/java/de/hysky/skyblocker/skyblock/tabhud/config/preview/PreviewWidget.java # src/main/java/de/hysky/skyblocker/skyblock/tabhud/screenbuilder/WidgetManager.java # src/main/java/de/hysky/skyblocker/skyblock/tabhud/widget/ComponentBasedWidget.java # src/main/java/de/hysky/skyblocker/utils/render/gui/DropdownWidget.java
# Conflicts: # src/main/java/de/hysky/skyblocker/skyblock/tabhud/config/preview/PreviewTab.java # src/main/java/de/hysky/skyblocker/utils/render/gui/DropdownWidget.java
# Conflicts: # src/main/java/de/hysky/skyblocker/skyblock/tabhud/config/WidgetsElementList.java # src/main/java/de/hysky/skyblocker/skyblock/tabhud/config/WidgetsListScreen.java
# Conflicts: # src/main/java/de/hysky/skyblocker/SkyblockerMod.java # src/main/java/de/hysky/skyblocker/config/categories/MiningCategory.java # src/main/java/de/hysky/skyblocker/config/categories/UIAndVisualsCategory.java # src/main/java/de/hysky/skyblocker/skyblock/galatea/TreeBreakProgressHud.java # src/main/java/de/hysky/skyblocker/skyblock/tabhud/config/WidgetsElementList.java # src/main/java/de/hysky/skyblocker/skyblock/tabhud/config/WidgetsListScreen.java # src/main/java/de/hysky/skyblocker/skyblock/tabhud/screenbuilder/pipeline/PositionRule.java # src/main/java/de/hysky/skyblocker/skyblock/tabhud/util/PlayerListManager.java # src/main/java/de/hysky/skyblocker/skyblock/tabhud/widget/ComponentBasedWidget.java # src/main/java/de/hysky/skyblocker/utils/CodecUtils.java
# Conflicts: # src/main/java/de/hysky/skyblocker/skyblock/tabhud/config/WidgetsConfigurationScreen.java # src/main/java/de/hysky/skyblocker/skyblock/tabhud/util/PlayerListManager.java
# Conflicts: # src/main/java/de/hysky/skyblocker/skyblock/tabhud/config/WidgetsConfigurationScreen.java # src/main/java/de/hysky/skyblocker/skyblock/tabhud/config/WidgetsListScreen.java # src/main/java/de/hysky/skyblocker/skyblock/tabhud/config/preview/PreviewTab.java # src/main/java/de/hysky/skyblocker/skyblock/tabhud/config/preview/PreviewWidget.java # src/main/java/de/hysky/skyblocker/skyblock/tabhud/screenbuilder/ScreenBuilder.java # src/main/java/de/hysky/skyblocker/skyblock/tabhud/screenbuilder/pipeline/WidgetPositioner.java # src/main/java/de/hysky/skyblocker/skyblock/tabhud/util/PlayerListManager.java # src/main/java/de/hysky/skyblocker/skyblock/tabhud/widget/PlayerListWidget.java
# Conflicts: # src/main/java/de/hysky/skyblocker/config/categories/FarmingCategory.java # src/main/java/de/hysky/skyblocker/config/categories/ForagingCategory.java # src/main/java/de/hysky/skyblocker/config/categories/HelperCategory.java # src/main/java/de/hysky/skyblocker/config/categories/HuntingCategory.java # src/main/java/de/hysky/skyblocker/config/categories/MiningCategory.java # src/main/java/de/hysky/skyblocker/config/categories/OtherLocationsCategory.java # src/main/java/de/hysky/skyblocker/config/categories/SlayersCategory.java # src/main/java/de/hysky/skyblocker/config/categories/UIAndVisualsCategory.java # src/main/java/de/hysky/skyblocker/config/configs/UIAndVisualsConfig.java # src/main/java/de/hysky/skyblocker/mixins/ClientPlayNetworkHandlerMixin.java # src/main/java/de/hysky/skyblocker/mixins/GuiMixin.java # src/main/java/de/hysky/skyblocker/mixins/HandledScreenProviderMixin.java # src/main/java/de/hysky/skyblocker/skyblock/ItemPickupWidget.java # src/main/java/de/hysky/skyblocker/skyblock/dungeon/DungeonSplitsWidget.java # src/main/java/de/hysky/skyblocker/skyblock/dwarven/CrystalsHudWidget.java # src/main/java/de/hysky/skyblocker/skyblock/dwarven/PickobulusHudWidget.java # src/main/java/de/hysky/skyblocker/skyblock/dwarven/profittrackers/PowderMiningWidget.java # src/main/java/de/hysky/skyblocker/skyblock/end/EndHudWidget.java # src/main/java/de/hysky/skyblocker/skyblock/fishing/FishingHudWidget.java # src/main/java/de/hysky/skyblocker/skyblock/galatea/SweepDetailsHudWidget.java # src/main/java/de/hysky/skyblocker/skyblock/galatea/TreeBreakProgressHud.java # src/main/java/de/hysky/skyblocker/skyblock/garden/FarmingHudWidget.java # src/main/java/de/hysky/skyblocker/skyblock/hunting/LassoHud.java # src/main/java/de/hysky/skyblocker/skyblock/slayers/hud/SlayerHudWidget.java # src/main/java/de/hysky/skyblocker/skyblock/tabhud/TabHud.java # src/main/java/de/hysky/skyblocker/skyblock/tabhud/config/WidgetsConfigurationScreen.java # src/main/java/de/hysky/skyblocker/skyblock/tabhud/config/WidgetsElementList.java # src/main/java/de/hysky/skyblocker/skyblock/tabhud/config/WidgetsListTab.java # src/main/java/de/hysky/skyblocker/skyblock/tabhud/config/entries/WidgetEntry.java # src/main/java/de/hysky/skyblocker/skyblock/tabhud/config/preview/PreviewTab.java # src/main/java/de/hysky/skyblocker/skyblock/tabhud/config/preview/PreviewWidget.java # src/main/java/de/hysky/skyblocker/skyblock/tabhud/screenbuilder/ScreenBuilder.java # src/main/java/de/hysky/skyblocker/skyblock/tabhud/screenbuilder/WidgetManager.java # src/main/java/de/hysky/skyblocker/skyblock/tabhud/screenbuilder/pipeline/WidgetPositioner.java # src/main/java/de/hysky/skyblocker/skyblock/tabhud/util/PlayerListManager.java # src/main/java/de/hysky/skyblocker/skyblock/tabhud/widget/CommsWidget.java # src/main/java/de/hysky/skyblocker/skyblock/tabhud/widget/ComponentBasedWidget.java # src/main/java/de/hysky/skyblocker/skyblock/tabhud/widget/ComposterWidget.java # src/main/java/de/hysky/skyblocker/skyblock/tabhud/widget/DungeonBuffWidget.java # src/main/java/de/hysky/skyblocker/skyblock/tabhud/widget/DungeonDeathWidget.java # src/main/java/de/hysky/skyblocker/skyblock/tabhud/widget/DungeonDownedWidget.java # src/main/java/de/hysky/skyblocker/skyblock/tabhud/widget/DungeonPlayerWidget.java # src/main/java/de/hysky/skyblocker/skyblock/tabhud/widget/DungeonPuzzleWidget.java # src/main/java/de/hysky/skyblocker/skyblock/tabhud/widget/DungeonSecretWidget.java # src/main/java/de/hysky/skyblocker/skyblock/tabhud/widget/DungeonServerWidget.java # src/main/java/de/hysky/skyblocker/skyblock/tabhud/widget/EffectWidget.java # src/main/java/de/hysky/skyblocker/skyblock/tabhud/widget/HudWidget.java # src/main/java/de/hysky/skyblocker/skyblock/tabhud/widget/JacobsContestWidget.java # src/main/java/de/hysky/skyblocker/skyblock/tabhud/widget/MinionWidget.java # src/main/java/de/hysky/skyblocker/skyblock/tabhud/widget/PlayerListWidget.java # src/main/java/de/hysky/skyblocker/skyblock/tabhud/widget/PowderWidget.java # src/main/java/de/hysky/skyblocker/skyblock/tabhud/widget/TabHudWidget.java # src/main/java/de/hysky/skyblocker/skyblock/tabhud/widget/TableWidget.java # src/main/java/de/hysky/skyblocker/skyblock/tabhud/widget/VisitorsWidget.java # src/main/java/de/hysky/skyblocker/skyblock/tabhud/widget/component/Components.java # src/main/java/de/hysky/skyblocker/skyblock/tabhud/widget/component/IcoTextComponent.java # src/main/java/de/hysky/skyblocker/skyblock/tabhud/widget/component/ProgressComponent.java # src/main/java/de/hysky/skyblocker/skyblock/waypoint/AbstractWaypointsScreen.java # src/main/java/de/hysky/skyblocker/utils/render/gui/AbstractWidget.java # src/main/java/de/hysky/skyblocker/utils/render/gui/DropdownWidget.java
# Conflicts: # src/main/java/de/hysky/skyblocker/skyblock/dwarven/PickobulusHudWidget.java # src/main/java/de/hysky/skyblocker/skyblock/garden/FarmingHudWidget.java # src/main/java/de/hysky/skyblocker/skyblock/tabhud/widget/ComponentBasedWidget.java # src/main/java/de/hysky/skyblocker/skyblock/tabhud/widget/component/Components.java
some other tweaks too
# Conflicts: # src/main/java/de/hysky/skyblocker/skyblock/ItemPickupWidget.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening as a draft. I want opinions, I do not want to touch this ever again. Please go ham on reviewing
Left to do
How does one implement widgets with this dang thing?
If you directly extend
HudWidgetyou just need to implement 3 methods huzzah!renderWidgetrenderConfiggetInformationContains: id for config, name for the config screen, where it can be added with right click.then you register your widget with the annotation or by adding it manually.
You can extend the
getOptionsmethod to add options duh. They will be accessible when right clicking a widget in the config screen. These options will be common to every location and layer. For per location and layer you can extendgetPerScreenOptions(might change to just per location perchance but that would mean changing positioning since that's stored in there)I added some options to
ComponentBasedWidgetif you want to check that out.Other stuff
PlayerListManagerwas changed you can check it out,TabHudWidgetwas changed so implementations don't need to change anything.May add more to this PR message