Skip to content

Conversation

@olim88
Copy link
Contributor

@olim88 olim88 commented Aug 3, 2025

image

creates radial menus for lots of skyblock gui. With mouse or keyboard navigation. and granular auto generated config for each menu

Missing menus?

I have created it for all I can think of but its very easy to add to a new menu if anybody has a suggestion.

suggestion

https://discord.com/channels/879732108745125969/1385681548489261167

demo video

Screencast_20250803_180458.mp4

@olim88 olim88 added the new feature This issue or PR is a new feature label Aug 3, 2025
@LifeIsAParadox LifeIsAParadox added the reviews needed This PR needs reviews label Aug 3, 2025
Copy link
Collaborator

@viciscat viciscat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

holy that's pretty cool. Directly, just for the sake of consistency and what not, RadialMenu could implement ContainerMatcher. But idk if you could sneak in RegexContainerMatcher neatly anywhere

@olim88
Copy link
Contributor Author

olim88 commented Aug 3, 2025

holy that's pretty cool. Directly, just for the sake of consistency and what not, RadialMenu could implement ContainerMatcher. But idk if you could sneak in RegexContainerMatcher neatly anywhere

I had a look into doing this but I don't think that it will work. The radial screen is created instead of the inventory screen so there is no screen to match to before the radial screen is created witch is when the test function of ContainerMatcher` would need to be used to work out if to show the radial menu.

Copy link
Collaborator

@viciscat viciscat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finally getting around reviewing this

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

public abstract class RegexMenu extends BasicMenu {
private final Pattern pattern;

public RegexMenu(String regex, String id) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Language("RegExp") annotation

@LifeIsAParadox LifeIsAParadox added changes requested This PR need changes reviews needed This PR needs reviews and removed reviews needed This PR needs reviews changes requested This PR need changes labels Sep 19, 2025
viciscat
viciscat previously approved these changes Oct 12, 2025
Copy link
Collaborator

@viciscat viciscat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me but considering the size someone else should take a peek

@LifeIsAParadox LifeIsAParadox added merge me please Pull requests that are ready to merge and removed reviews needed This PR needs reviews labels Oct 12, 2025
@Alex33856 Alex33856 added merge conflicts This PR has merge conflicts that need solving. and removed merge me please Pull requests that are ready to merge labels Oct 15, 2025
@LifeIsAParadox LifeIsAParadox added reviews needed This PR needs reviews and removed merge conflicts This PR has merge conflicts that need solving. labels Nov 3, 2025
@Alex33856 Alex33856 added merge conflicts This PR has merge conflicts that need solving. and removed reviews needed This PR needs reviews labels Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge conflicts This PR has merge conflicts that need solving. new feature This issue or PR is a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants