-
-
Notifications
You must be signed in to change notification settings - Fork 158
Add Radial Menus for Inventory Guis #1566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
viciscat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
holy that's pretty cool. Directly, just for the sake of consistency and what not, RadialMenu could implement ContainerMatcher. But idk if you could sneak in RegexContainerMatcher neatly anywhere
I had a look into doing this but I don't think that it will work. The radial screen is created instead of the inventory screen so there is no screen to match to before the radial screen is created witch is when the |
viciscat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
finally getting around reviewing this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo
| public abstract class RegexMenu extends BasicMenu { | ||
| private final Pattern pattern; | ||
|
|
||
| public RegexMenu(String regex, String id) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Language("RegExp") annotation
src/main/java/de/hysky/skyblocker/skyblock/radialMenu/RadialMenuScreen.java
Show resolved
Hide resolved
src/main/java/de/hysky/skyblocker/utils/render/gui/state/CustomShapeGuiElementRenderState.java
Show resolved
Hide resolved
viciscat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine by me but considering the size someone else should take a peek
and hunting menu
redo navigation to support keyboad navigation
creates radial menus for lots of skyblock gui. With mouse or keyboard navigation. and granular auto generated config for each menu
Missing menus?
I have created it for all I can think of but its very easy to add to a new menu if anybody has a suggestion.
suggestion
https://discord.com/channels/879732108745125969/1385681548489261167
demo video
Screencast_20250803_180458.mp4