Build sources jar #1859
Open
Build sources jar #1859
+24
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR adds support for building and publishing a sources JAR alongside the main mod JAR to Modrinth, GitHub Releases, and GitHub Packages.
Key changes:
- Added conditional sources JAR generation controlled by the
BUILD_SOURCES_JARenvironment variable - Configured Maven publication to GitHub Packages with proper credentials
- Fixed several typos in build script comments
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| build.gradle | Added conditional sources JAR generation via withSourcesJar(), configured sources JAR inclusion in publishMods, set up Maven publication with GitHub Packages repository, and fixed typos in comments |
| .github/workflows/buildrelease.yml | Added BUILD_SOURCES_JAR environment variable and included publish task to publish to GitHub Packages |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
isn't publishing sources to github kinda useless since it already has sources? |
Collaborator
Author
This allows people to use github packages as a maven repo. Currently you can't use github as the maven repo. |
Collaborator
|
mmok |
Collaborator
Author
|
I pushed to the wrong branch dammit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build sources jar and publish to modrinth and github packages.