Accessory helper #1889
Open
Accessory helper #1889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also put the item name on the second line for the "after selling" price
and move things around
Collaborator
|
Yes expressions should only be used when absolutely necessary since I doubt the remapper can handle them properly and updating them is hell. |
Collaborator
Author
|
I think this is a fine enough spot to put use them as targeting local variables are a pain without |
Collaborator
What are you even trying to modify with them exactly? |
Collaborator
Author
|
GenericContainerScreen doesn't use the and |
AzureAaron
requested changes
Dec 12, 2025
src/main/java/de/hysky/skyblocker/skyblock/item/SkyblockItemRarity.java
Outdated
Show resolved
Hide resolved
Collaborator
There was a problem hiding this comment.
Pretty sure you can just slice for the one you want.
Collaborator
Author
There was a problem hiding this comment.
but i liek expressions :((
more readable than to target the first changed local or whatever
LifeIsAParadox
added
merge conflicts
# Conflicts: # src/main/java/de/hysky/skyblocker/config/categories/HelperCategory.java # src/main/java/de/hysky/skyblocker/config/configs/HelperConfig.java # src/main/java/de/hysky/skyblocker/utils/container/ContainerSolverManager.java # src/main/resources/assets/skyblocker/lang/en_us.json
LifeIsAParadox
removed
the
merge conflicts
Alex33856
added
the
merge conflicts
# Conflicts: # src/main/java/de/hysky/skyblocker/config/configs/HelperConfig.java # src/main/java/de/hysky/skyblocker/mixins/accessors/HandledScreenAccessor.java # src/main/java/de/hysky/skyblocker/skyblock/accessories/AccessoriesHelper.java # src/main/java/de/hysky/skyblocker/skyblock/item/SkyblockItemRarity.java # src/main/java/de/hysky/skyblocker/skyblock/item/tooltip/adders/AccessoryTooltip.java # src/main/java/de/hysky/skyblocker/utils/container/ContainerSolverManager.java # src/main/resources/skyblocker.mixins.json
LifeIsAParadox
removed
the
merge conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Displays missing accessories and upgrades for your existing accessories
You can click on the things to open them on the wiki
This PR also changes behavior a bit for
GenericContainerScreento make it follow thexandyfields instead of ignoring them.I used expressions for this because they are neat.
I know @AzureAaron isn't a big fan of em so if you want me to change it I can but very reluctantly.