Skip to content

Slayers Fixes and new Features#1932

Merged
Alex33856 merged 37 commits intoSkyblockerMod:masterfrom
7azeemm:Slayers
Jan 30, 2026
Merged

Slayers Fixes and new Features#1932
Alex33856 merged 37 commits intoSkyblockerMod:masterfrom
7azeemm:Slayers

Conversation

@7azeemm
Copy link
Contributor

@7azeemm 7azeemm commented Dec 12, 2025 •
edited
Loading

Todo list:

  • Hide miniboss spawn message
  • Option to toggle alerting other people minibosses
  • Display alert for new personal best kill time
  • Make Command for showing slayers personal bests
  • Fix boss/miniboss spawn alert sound being too low
  • Add Option to show miniboss's name in spawn alert
  • Fix slayer quest detection not working in certain conditions
  • Select player's boss (if not detected due to it spawning far from player) or other people's boss on hit (won't select other bosses if player's boss is alive) (important for carries)
  • Fix Bossbar not being removed after boss kill
  • Make slayer timer ends when boss death detected instead of relying on slain msg in chat (use as fallback) (0.5s less)
  • Fix higher tier minibosses than boss tier being alerted (Slayer miniboss alerts for a higher slayer level shouldn't show #1915)
  • Highlight unclaimed slayer levels rewards
  • Replace slayers icons with their custom textures (the ones used in pv) in Slayer HUD
  • Cache slayers info (killing 1 boss will not be required for the HUD to work anymore)
  • Custom highlight color option
  • Fix Hitbox highlight color being always black
  • Spider Slayer
    • Fix new t5 minibosses highlighting
    • Mute Spider sounds (Spiders, Silverfishs, Bats, Skeletons Sounds)
    • Fix t5 second phase slayer detection
  • Enderman Slayer
    • Fix lazer timer not working correctly (it works now, but the accuracy of time depends on server tps)
    • Add timer to beacons
  • Blaze Slayer
    • Fix slayer detection after spliting
    • Hide Hellion Shield messages
    • Mute Blaze Sounds (Blazes, Lightning Bolts, Lava/Fire, Fireballs thrown by the slayer (Ghast sounds))
  • Wolf Slayer
    • Mute Wolf sounds
    • Hide Sven Pups nametags

Things to work on later:

  • Track time to spawn boss
  • Make fire pillar warning for only the player's boss
  • Kills/hr and Estimated time to lvl up in Slayer HUD
  • HUD for RNG meter xp, selected item, kills left, drop chance

Copilot AI review requested due to automatic review settings December 12, 2025 19:30
@LifeIsAParadox LifeIsAParadox added the reviews needed This PR needs reviews label Dec 12, 2025
@7azeemm 7azeemm marked this pull request as draft December 12, 2025 19:33
@LifeIsAParadox LifeIsAParadox added merge conflicts This PR has merge conflicts that need solving. wip This PR is a work in progress and removed reviews needed This PR needs reviews labels Dec 12, 2025
Copilot AI reviewed Dec 12, 2025
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses various slayer-related fixes and features, with the primary focus on fixing the Enderman slayer laser timer functionality. The changes refactor the timer logic to use a cooldown-based activation system rather than tracking the riding state.

Key Changes:

  • Refactored Enderman laser timer with 10-second activation cooldown to prevent rapid re-triggering
  • Simplified timer tick logic and removed dependency on vehicle state tracking
  • Changed default behavior to mute enderman sounds in The End

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
LazerTimer.java Refactored timer from riding-state-based to activation-cooldown-based system with simplified tick logic and updated rendering
EntityMixin.java Simplified tick method logic and removed unused shadow methods (getVehicle()) and imports
OtherLocationsConfig.java Changed default value for muteEndermanSounds from false to true in The End configuration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@LifeIsAParadox LifeIsAParadox removed the merge conflicts This PR has merge conflicts that need solving. label Dec 13, 2025
@LifeIsAParadox LifeIsAParadox added the merge conflicts This PR has merge conflicts that need solving. label Dec 13, 2025
@LifeIsAParadox LifeIsAParadox removed the merge conflicts This PR has merge conflicts that need solving. label Dec 13, 2025
@LifeIsAParadox LifeIsAParadox added merge conflicts This PR has merge conflicts that need solving. and removed merge conflicts This PR has merge conflicts that need solving. labels Dec 13, 2025
@7azeemm 7azeemm force-pushed the Slayers branch 2 times, most recently from 7c8753f to 1952562 Compare December 13, 2025 13:40
@LifeIsAParadox LifeIsAParadox added the merge conflicts This PR has merge conflicts that need solving. label Dec 13, 2025
@LifeIsAParadox LifeIsAParadox removed the merge conflicts This PR has merge conflicts that need solving. label Dec 13, 2025
@Alex33856 Alex33856 added the merge conflicts This PR has merge conflicts that need solving. label Dec 13, 2025
@LifeIsAParadox LifeIsAParadox added reviews needed This PR needs reviews and removed merge conflicts This PR has merge conflicts that need solving. labels Jan 24, 2026
Alex33856
Alex33856 requested changes Jan 24, 2026
View reviewed changes
@LifeIsAParadox LifeIsAParadox added changes requested This PR need changes and removed reviews needed This PR needs reviews labels Jan 24, 2026
@7azeemm
Merge branch 'refs/heads/master' into Slayers
c34e390 
# Conflicts:
#	src/main/java/de/hysky/skyblocker/config/categories/SlayersCategory.java
#	src/main/java/de/hysky/skyblocker/mixins/ClientPacketListenerMixin.java
#	src/main/java/de/hysky/skyblocker/mixins/EntityMixin.java
#	src/main/java/de/hysky/skyblocker/mixins/EntityRendererMixin.java
#	src/main/java/de/hysky/skyblocker/skyblock/slayers/SlayerManager.java
Alex33856
Alex33856 requested changes Jan 25, 2026
View reviewed changes
Alex33856
Alex33856 previously approved these changes Jan 27, 2026
View reviewed changes
Copy link
Contributor

@Alex33856 Alex33856 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine.

Didn't test with Blaze or Vampire Slayer

@LifeIsAParadox LifeIsAParadox added merge me please Pull requests that are ready to merge and removed changes requested This PR need changes labels Jan 27, 2026
AzureAaron
AzureAaron previously approved these changes Jan 27, 2026
View reviewed changes
@Alex33856 Alex33856 dismissed stale reviews from AzureAaron and themself via b4cc2d7 January 28, 2026 00:08
@LifeIsAParadox LifeIsAParadox added changes requested This PR need changes and removed merge me please Pull requests that are ready to merge labels Jan 28, 2026
@LifeIsAParadox LifeIsAParadox added merge me please Pull requests that are ready to merge and removed changes requested This PR need changes labels Jan 28, 2026
@Alex33856 Alex33856 merged commit dc309c3 into SkyblockerMod:master Jan 30, 2026
2 checks passed
@LifeIsAParadox LifeIsAParadox removed the merge me please Pull requests that are ready to merge label Jan 30, 2026
Alex33856 pushed a commit that referenced this pull request Jan 30, 2026
@7azeemm @Alex33856
Slayers Fixes and new Features (#1932)
8fc03ee 
* Reworked LazerTimer

* Made `muteEndermanSounds` true by default

* Option to hide miniboss spawn message in chat

* Boss kill time is now sent on boss death instead of relying on chat message (0.5s diff)

* Fixed sound alert volume being too low and changed title alert to miniboss's name

* made new personal best shows in titleContainer

* Added option for showing miniboss name in alert

* Unclaimed slayer lvl rewards highlighter

* Fixed Bossbar not removed after boss kill

* Simplified few things

* Mute blaze sounds feature

* Fixed Quest Detection

* Cached slayers info

* Slayer HUD now uses slayer's custom head texture instead of mob drop icon, also removed Unknown enum value from SlayerTier and SlayerType

* Improved Miniboss detection performance and Fixed alerting for higher tier minibosses compared to boss tier

* Improvements to Boss Detection and other stuff

* Added option to mute wolf sounds

* Separated BossFight and SlayerQuest so player can select other people's boss on hit, Also Fixed other stuff like bossbar and slayer timer

* Option to hide Sven Pup's nametag

* Added Highlight Color option and Fixed Hitbox wasn't working, also `attunement highlights` does not require `highlightBosses` to be set anymore

* Added hide hellion shield filter

* Added Timer to BeaconHighlighter

* lots of changes

* Fixed some stuff

* 1.21.11

* changes

* Changes

* resolving conflicts

* changes

* changes

* fixed miniboss alert

* Fix Config Option

* Use ColorUtils#getFloatComponents

(cherry picked from commit dc309c3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@Alex33856 Alex33856 Alex33856 approved these changes

@AzureAaron AzureAaron AzureAaron approved these changes

@kevinthegreat1 kevinthegreat1 kevinthegreat1 left review comments

@viciscat viciscat Awaiting requested review from viciscat

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

6.0.0

Development

Successfully merging this pull request may close these issues.

7 participants

@7azeemm @Alex33856 @viciscat @AzureAaron @kevinthegreat1 @LifeIsAParadox