Skip to content

Conversation

@7azeemm
Copy link
Contributor

@7azeemm 7azeemm commented Dec 12, 2025

Todo list:

  • Kills/hr
  • Estimated time to lvl up
  • Hide miniboss spawn message in chat
  • RNG meter xp, selected item, kills left, drop chance
  • Highlight best item in RNG meter for profit (not for slayers only, for every meter)
  • Fix eman lazer timer not working correctly
  • Spider Stuff
  • Display new personal best kill time in titleContainer
  • Make Command for showing slayers personal bests (and maybe show them in pv?)
  • Add sound alert alongside title for miniboss/boss alert
  • Add Option to show miniboss's name in spawn alert
  • Fix slayer quest detection not working in certain conditions
  • Fix Blaze Slayer detection after spliting
  • Select player's boss (if not detected due to it spawning far from player) or other people's boss on hit (won't select other bosses if player's boss is alive) (important for carries or if boss not detected)
  • Fix Bossbar not being removed after boss kill
  • Detailed Breakdown of the quest on chat message hover (spawn/kill time, phases times?)
  • Make fire pillar warning for only the player's boss
  • Make slayer timer ends when boss death detected instead of relying on slain msg in chat (use as fallback)
  • Mute Blaze Sounds
  • Fix higher tier minibosses than boss tier being alerted (Slayer miniboss alerts for a higher slayer level shouldn't show #1915)
  • Highlight unclaimed slayer levels rewards
  • Replace slayers icons with their custom textures (the ones used in pv) in hud
  • Cache slayers info (killing one boss will not be required for the hud to work + needed for RNG meter item tracker)
  • Mute Wolf sounds
  • Hide Sven Pups nametags
  • Hide blaze hellion shield messages
  • Add timer to eman beacon
  • Custom highlight color option
  • Fix Hitbox highlight color being always black
  • Mute Spider sounds

Copilot AI review requested due to automatic review settings December 12, 2025 19:30
@LifeIsAParadox LifeIsAParadox added the reviews needed This PR needs reviews label Dec 12, 2025
@7azeemm 7azeemm marked this pull request as draft December 12, 2025 19:33
@LifeIsAParadox LifeIsAParadox added merge conflicts This PR has merge conflicts that need solving. wip This PR is a work in progress and removed reviews needed This PR needs reviews labels Dec 12, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses various slayer-related fixes and features, with the primary focus on fixing the Enderman slayer laser timer functionality. The changes refactor the timer logic to use a cooldown-based activation system rather than tracking the riding state.

Key Changes:

  • Refactored Enderman laser timer with 10-second activation cooldown to prevent rapid re-triggering
  • Simplified timer tick logic and removed dependency on vehicle state tracking
  • Changed default behavior to mute enderman sounds in The End

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
LazerTimer.java Refactored timer from riding-state-based to activation-cooldown-based system with simplified tick logic and updated rendering
EntityMixin.java Simplified tick method logic and removed unused shadow methods (getVehicle()) and imports
OtherLocationsConfig.java Changed default value for muteEndermanSounds from false to true in The End configuration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@LifeIsAParadox LifeIsAParadox removed the merge conflicts This PR has merge conflicts that need solving. label Dec 13, 2025
@LifeIsAParadox LifeIsAParadox added the merge conflicts This PR has merge conflicts that need solving. label Dec 13, 2025
@LifeIsAParadox LifeIsAParadox removed the merge conflicts This PR has merge conflicts that need solving. label Dec 13, 2025
@LifeIsAParadox LifeIsAParadox added merge conflicts This PR has merge conflicts that need solving. and removed merge conflicts This PR has merge conflicts that need solving. labels Dec 13, 2025
@7azeemm 7azeemm force-pushed the Slayers branch 2 times, most recently from 7c8753f to 1952562 Compare December 13, 2025 13:40
@LifeIsAParadox LifeIsAParadox added the merge conflicts This PR has merge conflicts that need solving. label Dec 13, 2025
@LifeIsAParadox LifeIsAParadox removed the merge conflicts This PR has merge conflicts that need solving. label Dec 13, 2025
@Alex33856 Alex33856 added the merge conflicts This PR has merge conflicts that need solving. label Dec 13, 2025
@LifeIsAParadox LifeIsAParadox removed the merge conflicts This PR has merge conflicts that need solving. label Dec 14, 2025
@LifeIsAParadox LifeIsAParadox added the merge conflicts This PR has merge conflicts that need solving. label Dec 16, 2025
…'s boss on hit, Also Fixed other stuff like bossbar and slayer timer
@LifeIsAParadox LifeIsAParadox removed the merge conflicts This PR has merge conflicts that need solving. label Dec 17, 2025
…ttunement highlights` does not require `highlightBosses` to be set anymore
@LifeIsAParadox LifeIsAParadox added the merge conflicts This PR has merge conflicts that need solving. label Dec 17, 2025
@LifeIsAParadox LifeIsAParadox removed the merge conflicts This PR has merge conflicts that need solving. label Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

wip This PR is a work in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants