Update DungeonsSpecialEffects.java #1943
Open
+121
−81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use CROESUS_PATTERN instead of DROP_PATTERN cuz DROP_PATTERN requires player picking items and that's slow - Remove player name detection - Add m3-m5 star and shadow fury - Add recomb <del>to see more effects</del> cuz it is the most profitable/rare item in low floors and also nice in high floors - Separate scrolls cuz they may have different looks if player is using resource pack
Collaborator
|
Has this been tested? (Have you dropped something while using these changes?) |
Contributor
Author
ofc i did 40 runs |
Collaborator
|
This still works outside of croesus right? Like opening the chests directly at dungeon end. |
Contributor
Author
Yes. Although I call it CROESUS_PATTERN, the text for opening the chest is the same both inside and outside the dungeon. |
- Rename rareDungeonDropEffects to rareDropEffects - Use DUNGEON_CHEST_PATTERN and MAGIC_FIND_PATTERN instead of CROESUS_PATTERN. now we can add more rare items.
- Fix regex - Add more items
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to see more effectscuz it is the most profitable/rare item in low floors and also nice in high floors