-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Update API specifications with fern api update #3696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Caution
Changes requested ❌
Reviewed everything up to 390acfb in 2 minutes and 4 seconds. Click for details.
- Reviewed
70
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
4
draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. fern/openapi/skyvern_openapi.json:2533
- Draft comment:
For the 'xpath' field, consider using OpenAPI's 'nullable: true' with type 'string' instead of an 'anyOf' for nullability. This may simplify the schema. - Reason this comment was not posted:
Confidence changes required:50%
<= threshold50%
None
2. fern/openapi/skyvern_openapi.json:8330
- Draft comment:
Ensure the 'totp_type' field's default value 'none' is correct and aligns with backend logic for this credential schema. - Reason this comment was not posted:
Confidence changes required:30%
<= threshold50%
None
3. fern/openapi/skyvern_openapi.json:8676
- Draft comment:
The 'totp_type' field is added consistently here. Confirm that its default and example values match expectations across schemas. - Reason this comment was not posted:
Confidence changes required:30%
<= threshold50%
None
4. fern/openapi/skyvern_openapi.json:10954
- Draft comment:
The TotpType enum definition appears correct. Verify that the enumerated values ('authenticator', 'email', 'text', 'none') fully cover the allowed 2FA methods. - Reason this comment was not posted:
Confidence changes required:30%
<= threshold50%
None
Workflow ID: wflow_DbmVUMfMEwucVbOH
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
"type": "null" | ||
} | ||
], | ||
"title": "Xpath" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: Consider capitalizing 'Xpath' to 'XPath' if that is the intended terminology.
"title": "Xpath" | |
"title": "XPath" |
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. WalkthroughIntroduces a new TotpType enum in the OpenAPI spec and adds fields referencing it. Extends Action with an optional xpath field. Adds totp_type to NonEmptyPasswordCredential and PasswordCredentialResponse. All changes are within fern/openapi/skyvern_openapi.json. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Update API specifications by running fern api update.
🔧 This PR updates the API specifications by running
fern api update
, adding new TOTP authentication fields and XPath support to enhance the OpenAPI schema with better 2FA handling and element targeting capabilities.🔍 Detailed Analysis
Key Changes
totp_type
field to credential schemas with enum values (authenticator
,email
,text
,none
) for supporting different 2FA methodsxpath
field (string or null) to tool call specifications for better element targetingTotpType
enum schema definition with comprehensive 2FA method optionsTechnical Implementation
Impact
Created with Palmier
Important
Update
skyvern_openapi.json
to include newxpath
andtotp_type
properties andTotpType
schema.xpath
property toskyvern_openapi.json
withstring
ornull
type.totp_type
property toskyvern_openapi.json
with reference toTotpType
schema, defaultnone
, and exampleauthenticator
.TotpType
schema toskyvern_openapi.json
withenum
values:authenticator
,email
,text
,none
.This description was created by
for 390acfb. You can customize this summary. It will automatically update as commits are pushed.
Summary by CodeRabbit