-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Update API specifications with fern api update #3700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update API specifications with fern api update #3700
Conversation
WalkthroughAdds a new TotpType enum schema and integrates it into credential-related schemas. Introduces a totp_type field to NonEmptyPasswordCredential and PasswordCredentialResponse. Adds an optional xpath field to the Action schema. All changes occur within fern/openapi/skyvern_openapi.json. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed everything up to 90f421c in 2 minutes and 36 seconds. Click for details.
- Reviewed
70
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
4
draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. fern/openapi/skyvern_openapi.json:2532
- Draft comment:
For the new 'xpath' field, if using OpenAPI 3, consider using 'nullable': true instead of an anyOf construct to simplify the schema. - Reason this comment was not posted:
Confidence changes required:50%
<= threshold50%
None
2. fern/openapi/skyvern_openapi.json:8320
- Draft comment:
The 'totp_type' field has a default value 'none' but an example value of 'authenticator'. Verify if this discrepancy is intentional. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
3. fern/openapi/skyvern_openapi.json:10955
- Draft comment:
Consider renaming 'TotpType' to 'TOTPType' for consistent acronym casing across the API. - Reason this comment was not posted:
Confidence changes required:30%
<= threshold50%
None
4. fern/openapi/skyvern_openapi.json:2543
- Draft comment:
Typographical suggestion: The title "Xpath" may be intended to reference "XPath" (the common XML Path Language). Consider updating this for consistency and correctness. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 20% vs. threshold = 50% Looking at the diff, this is a new field being added to the schema. The comment is about proper casing/naming of a technical term. While it's technically correct that "XPath" is the proper casing, this kind of minor typographical suggestion doesn't meet the bar for a required code change per the review rules. The rules state we should only keep comments that clearly require code changes, and to not make purely informative comments. The comment is technically accurate about the proper casing of XPath. The field name could potentially cause confusion if developers are searching for documentation. While accurate, this is a minor typographical issue that doesn't impact functionality. The meaning is still clear even with the current casing. The rules specifically say not to make purely informative comments. Delete the comment as it's a minor typographical suggestion that doesn't meet the bar for required code changes per the review rules.
Workflow ID: wflow_HHqBOV2wjYAnjvtg
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
Update API specifications by running fern api update.
🔧 This PR updates the API specifications by running
fern api update
, adding support for XPath tracking in tool calls and introducing a comprehensive TOTP (Time-based One-Time Password) type system for 2FA authentication methods.🔍 Detailed Analysis
Key Changes
xpath
field to tool call responses for better element tracking and debuggingTotpType
enum with four authentication methods:authenticator
,email
,text
, andnone
totp_type
field with proper defaults and examplesTechnical Implementation
Impact
Created with Palmier
Important
Updates
skyvern_openapi.json
with newxpath
andtotp_type
properties and definesTotpType
schema.xpath
property withstring
ornull
type toskyvern_openapi.json
.totp_type
property referencingTotpType
schema, with default "none" and example "authenticator".TotpType
schema with enum values: "authenticator", "email", "text", "none".This description was created by
for 90f421c. You can customize this summary. It will automatically update as commits are pushed.
Summary by CodeRabbit