Rework generation dataflow to avoid mutating parameters#1257
Closed
shueja wants to merge 6 commits intoSleipnirGroup:mainfrom
Closed
Rework generation dataflow to avoid mutating parameters#1257shueja wants to merge 6 commits intoSleipnirGroup:mainfrom
shueja wants to merge 6 commits intoSleipnirGroup:mainfrom
Conversation
Collaborator
Author
|
I tested with the
This demonstrates that the parameter section is no longer getting modified, but the snapshot section does still communicate the correct interval counts. |
calcmogul
reviewed
May 18, 2025
Member
There was a problem hiding this comment.
The implementation should link to this in relevant places so it's more likely to get updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously:
This results in bugs where the generator wipes away the expressions in waypoint headings. This was identified as a CLI bug, but it is a core bug that's masked by the way the frontend handles generation results.
New behavior:
snapshot.waypoints[n].intervalsfields..paramsAlso this PR has a new docs page explaining what parts of the TrajectoryFile change upon generation.
GenerationEquivalent
Since the end condition of generation no longer has total equivalence between the
paramsandsnapshot, the equality checks forupToDatehave been replaced with a custom traitGenerationEquivalent. This helps better capture aspects of parameters that are conditionally irrelevant. The special cases for equivalence where equality would not hold are currently as follows.Constraint: differences in data are ignored if both constraints are not enabled.Waypoint: differences inintervalsare ignored if bothoverride_intervalsare false.