AreaOfInterest subclass cleanup for all icesat2 dataframe classes.#561
Merged
AreaOfInterest subclass cleanup for all icesat2 dataframe classes.#561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I split the AreaOfInterest subclasses out of the AtlXXDataFrame classes into their own AreaOfInterestXX files. For example, Atl24DataFrame now uses AreaOfInterest24. I also added AreaSubset to centralize the polygon and raster span and mask logic for AreaOfInterest06, AreaOfInterest08, AreaOfInterest13, and AreaOfInterest24.
I looked at refactoring AreaOfInterest03 as well, but its segment to photon bookkeeping is complex and the code did not become smaller or clearer. To avoid regression risk, I left it as the existing standalone implementation, which appears to be mature and stable.