Skip to content

Implement converting PageContent's into HTML#231

Open
paypur wants to merge 63 commits intoSlimeKnights:1.20from
paypur:1.20_wiki
Open

Implement converting PageContent's into HTML#231
paypur wants to merge 63 commits intoSlimeKnights:1.20from
paypur:1.20_wiki

Conversation

@paypur
Copy link

@paypur paypur commented Jul 16, 2025

paypur added 12 commits July 10, 2025 11:44
@paypur
Modified the book export command to also export HTML
cd3b0cc 
Implemented IHTML for everything in Materials and You


Took 1 minute
@paypur
Disabled rendering text while using the book export command
4832a04 
Took 15 minutes
@paypur
Added linking between content
0e05794 
Took 1 hour 54 minutes
@paypur
Added partial styling support TextData for text using Minecraft's cha…
688b88c 
…t formatting system

Took 1 hour 57 minutes
@paypur
Fixed issue with chat formatting parser skipping text after the last …
380b5c6 
…formatting code
@paypur
Fixed NPE for toHTML(TextData[])
3b57a1f
@paypur
Updated HTMLUtils
4a1cfef
@paypur
Updated titles to use isCentered and isLarge
7a96272 
Took 2 hours 12 minutes
@paypur
Added dark blue to TextData#parseChatFormatting
bd7e363 
Took 14 minutes
@paypur
Updated ContentSectionList to allow for a 4th column
ea99169 
Took 9 minutes
@paypur
Did something
f27fa6e
@paypur
Reverted build.gradle
9b3a129 
Took 38 seconds
@paypur paypur marked this pull request as draft July 16, 2025 20:29
@paypur paypur mentioned this pull request Jul 16, 2025
Open
@KnightMiner
Copy link
Member

KnightMiner commented Jul 16, 2025

Its also worth asking, do you plan to implement tooltips or not? Its fine without tooltip; text + links is better than nothing. But want to know so I know how to review this.

KnightMiner
KnightMiner reviewed Jul 16, 2025
View reviewed changes
KnightMiner
KnightMiner reviewed Jul 16, 2025
View reviewed changes
KnightMiner
KnightMiner reviewed Jul 16, 2025
View reviewed changes
@paypur
Copy link
Author

paypur commented Jul 16, 2025 •
edited
Loading

I'll try but not in this pr

paypur added 2 commits July 16, 2025 18:32
@paypur
Added some javadocs
487e960 
Removed unnecessary spans and colors

Took 3 hours 23 minutes
@paypur
Moved exporting HTML to its own subcommand
9fb7e52 
Took 1 hour 45 minutes
fuj1n
fuj1n reviewed Jul 17, 2025
View reviewed changes
KnightMiner
KnightMiner reviewed Jan 24, 2026
View reviewed changes
@paypur
Copy link
Author

paypur commented Jan 24, 2026

Should be everything, but I'll need to test that I didn't break anything. As for the html classes you wrote, I think that would be better for a separate pr after this is merged, so its easier to compare before and after migrating.

@paypur
Copy link
Author

paypur commented Feb 8, 2026

I'm still working on this, I've just been a little busy

@KnightMiner
Copy link
Member

KnightMiner commented Feb 9, 2026 •
edited
Loading

One thought from SlimeKnights/TinkersConstruct#5577 is we may want to swap the bullet point from space to \u00a0, which would break your bullet point detection. Easiest thing to do is probably to check for either string, and use the \u00a0 version as the public string constant. Will let us gradually switch books to it.

@paypur paypur requested a review from KnightMiner March 21, 2026 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fuj1n fuj1n fuj1n left review comments

@KnightMiner KnightMiner Awaiting requested review from KnightMiner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@paypur @KnightMiner @fuj1n