Skip to content

Simplify reset code #1321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

ButterscotchV
Copy link
Member

@ButterscotchV ButterscotchV commented Feb 28, 2025

Our current reset code is a mess, we can absolutely annihilate gyroFix and leave it to yawFix to handle the yaw offset. I also want to remove tposeDownFix, but haven't done so yet.

There's also some really confusing logic between computed trackers, the head tracker, and different reset poses. I tackled a lot of that already, but I think there's more that can be cleaned up.

TODO

  • Write unit tests for computed trackers
  • Write unit tests for different reset poses
  • Make tposeDownFix handled locally (integrate into attachmentFix?)
  • Check if manual mounting orientation affects computed trackers

@ButterscotchV ButterscotchV added Difficulty: Math Heavy For something that requires some non-trivial math Priority: Low Less important right now Type: Enhancement Adds or improves a feature Area: Server Related to the server labels Feb 28, 2025
@ButterscotchV ButterscotchV self-assigned this Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Server Related to the server Difficulty: Math Heavy For something that requires some non-trivial math Priority: Low Less important right now Type: Enhancement Adds or improves a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant