differentiable reset sounds #1401
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
needs feedback on the reset start tones |
|
if using |
|
that sounds good and you can commit it; since reset sounds might be replaced again anyway i dont know if this should be worked on |
|
I mean until it gets changed why not |
Please feel free to reject if you like it less ^^ that is oki
|
I wanted to change only what @ImUrX asked, but I think I played too much. Please feel free to reject if you don't like. |
|
if you think it is good, that is more than likely fine for this pr |
ImUrX
force-pushed
the
differentiable-reset-sounds
branch
from
3206156 to
aa27526
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
original sounds between full reset and mounting could be differentiated by speed, so instead play a unique pattern
I am not sure this is needed, but maybe it is a good idea.